Skip to content

fix: handle broadcast allocation for range-backed QuantityArray #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MilesCranmer merged 2 commits into from
Apr 23, 2026
Merged

fix: handle broadcast allocation for range-backed QuantityArray #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cede780
fix: handle broadcast allocation for range-backed QuantityArray
MilesCranmerBot Apr 23, 2026
1953e8d
refactor: use @eval loop for quantity array similar
MilesCranmerBot Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/arrays.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,13 @@ function Base.similar(bc::Broadcast.Broadcasted{Broadcast.ArrayStyle{QA}}, ::Typ
first_output::ElType = materialize_first(bc)
return QuantityArray(output_array, dimension(first_output)::dim_type(ElType), ElType)
end
function Base.similar(bc::Broadcast.Broadcasted{Broadcast.ArrayStyle{QuantityArray{T,N,D,Q,V}}}, ::Type{ElType}) where {T,N,D,Q,V<:Array{T,N},ElType}
return similar(Array{ElType}, axes(bc))
for VSupertype in (:(Array{T,N}), :(AbstractRange{T}))
@eval function Base.similar(
bc::Broadcast.Broadcasted{Broadcast.ArrayStyle{QuantityArray{T,N,D,Q,V}}},
::Type{ElType},
) where {T,N,D,Q,V<:$VSupertype,ElType}
return similar(Array{ElType}, axes(bc))
end
end
function Base.similar(bc::Broadcast.Broadcasted{Broadcast.ArrayStyle{QuantityArray{T,N,D,Q,V}}}, ::Type{ElType}) where {T,N,D,Q,V,ElType}
# To deal with things like StaticArrays, we need to rely on
Expand Down
13 changes: 13 additions & 0 deletions test/unittests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,19 @@ end
@test RealQuantity(us"inch") * (1.0:4.0) isa QuantityArray
end

@testset "Broadcasting over QuantityArray with StepRangeLen backing" begin
struct WrappedQuantity{T}
value::T
end

t = QuantityArray(range(1.0, step=0.1, length=10), u"s")
wrapped = WrappedQuantity.(t)

@test wrapped isa Vector{WrappedQuantity{Quantity{Float64,typeof(dimension(u"s"))}}}
@test first(wrapped).value == first(t)
@test last(wrapped).value == last(t)
end

@testset "Array of quantities multiplication behavior" begin
# Test that array of quantities * quantity does NOT create nested QuantityArray
# but instead broadcasts properly
Expand Down
Loading