Extra examples#524
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
===========================================
+ Coverage 28.67% 50.72% +22.04%
===========================================
Files 8 8
Lines 265 276 +11
===========================================
+ Hits 76 140 +64
+ Misses 189 136 -53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I have been considering the approach we should take here. The documents from https://github.com/plotly/plotlyjs.jl-docs/tree/master/julia should be included in a new documentation section called 'Tutorials'. We can organise them into sub-categories in a later PR following the arrangement shown at https://plotly.com/julia/ Each file should have a new commented header, something like @tlyon3 Does this seem appropriate? |
| "Time Series" => "examples/time_series.md", | ||
| "Violin" => "examples/violin.md", | ||
| ], | ||
| "Extra Examples" => [ |
There was a problem hiding this comment.
| "Extra Examples" => [ | |
| "Tutorials" => [ |
| "Heatmaps" => "examples/heatmaps.md", | ||
| "Histograms" => "examples/histograms.md", | ||
| "Line and Scatter" => "examples/line_scatter.md", | ||
| "Line and Scatter" => "examples/line_scatter2.md", |
There was a problem hiding this comment.
I would keep the examples mostly as they are, but I think this should be under 'Tutorials' (aka extra-examples). Can line_scatter2.md and line-and-scatter.md be combined?
There was a problem hiding this comment.
Thanks for the comment.
The original line_scatter.md contains just a list of examples. line_scatter2.md tries to combine the examples from line-scatter.md, some explanation and the examples from https://plotly.com/julia/. There is also some overlapping between the examples at https://plotly.com/julia/ and those in PlotlyJS.jl: for line_scatter.md they are mostly duplicated.
Rebased on master