fix: guard PyDict REPL completion with GIL

Author: Beforerr

src/Core/Core.jl

@@ -11,6 +11,7 @@ const ROOT_DIR = dirname(dirname(@__DIR__))
 using ..PythonCall
 using ..C
 using ..GC: GC
+using ..GIL
 using ..Utils
 
 using Base: @propagate_inbounds, @kwdef

src/Core/Py.jl

@@ -125,10 +125,12 @@ Py(x::Date) = pydate(x)
 Py(x::Time) = pytime(x)
 Py(x::DateTime) = pydatetime(x)
 
-Base.string(x::Py) = pyisnull(x) ? "<py NULL>" : pystr(String, x)
+Base.string(x::Py) = GIL.@lock (pyisnull(x) ? "<py NULL>" : pystr(String, x))
 Base.print(io::IO, x::Py) = print(io, string(x))
 
-function Base.show(io::IO, x::Py)
+Base.show(io::IO, x::Py) = GIL.@lock _show(io, x)
+
+function _show(io::IO, x::Py)
     if get(io, :typeinfo, Any) == Py
         if pyisnull(x)
             print(io, "NULL")
@@ -149,7 +151,9 @@ function Base.show(io::IO, x::Py)
     end
 end
 
-function Base.show(io::IO, ::MIME"text/plain", o::Py)
+Base.show(io::IO, mime::MIME"text/plain", o::Py) = GIL.@lock _show(io, mime, o)
+
+function _show(io::IO, ::MIME"text/plain", o::Py)
     if pyisnull(o)
         str = "NULL"
     else

src/Wrap/PyDict.jl

@@ -15,7 +15,13 @@ end
 
 Base.length(x::PyDict) = Int(pylen(x))
 
-function Base.iterate(x::PyDict{K,V}, it::Py = pyiter(x)) where {K,V}
+Base.iterate(x::PyDict) = GIL.@lock _iterate(x, pyiter(x))
+
+function Base.iterate(x::PyDict{K,V}, it::Py) where {K,V}
+    GIL.@lock _iterate(x, it)
+end
+
+function _iterate(x::PyDict{K,V}, it::Py) where {K,V}
     k_ = unsafe_pynext(it)
     pyisnull(k_) && return nothing
     v_ = pygetitem(x, k_)
@@ -24,7 +30,13 @@ function Base.iterate(x::PyDict{K,V}, it::Py = pyiter(x)) where {K,V}
     return (k => v, it)
 end
 
-function Base.iterate(x::Base.KeySet{K,PyDict{K,V}}, it::Py = pyiter(x.dict)) where {K,V}
+Base.iterate(x::Base.KeySet{K,<:PyDict{K}}) where {K} = GIL.@lock _iterate(x, pyiter(x.dict))
+
+function Base.iterate(x::Base.KeySet{K,<:PyDict{K}}, it::Py) where {K}
+    GIL.@lock _iterate(x, it)
+end
+
+function _iterate(x::Base.KeySet{K,<:PyDict{K}}, it::Py) where {K}
     k_ = unsafe_pynext(it)
     pyisnull(k_) && return nothing
     k = pyconvert(K, k_)

src/Wrap/Wrap.jl

@@ -11,6 +11,7 @@ using ..NumpyDates
 using ..C
 using ..Core
 using ..Convert
+using ..GIL
 using ..PyMacro
 
 import ..PythonCall:

test/Wrap.jl

@@ -122,6 +122,18 @@ end
     @testset "iterate keys" begin
         @test collect(keys(z)) == ["foo"]
     end
+    @testset "complete keys without GIL" begin
+        using REPL
+        completion_count = PythonCall.GIL.@unlock begin
+            task = @async begin
+                completions, _, _ = REPL.REPLCompletions.completions("y[", 2, @__MODULE__)
+                length(completions)
+            end
+            wait(task)
+            fetch(task)
+        end
+        @test completion_count == 1
+    end
     @testset "getindex" begin
         @test z["foo"] === 12
         @test_throws KeyError z["bar"]