Skip to content

allow building sysimage with custom PyCall#422

Open
marius311 wants to merge 4 commits intoJuliaPy:masterfrom
marius311:custom_pycall_sysimage
Open

allow building sysimage with custom PyCall#422
marius311 wants to merge 4 commits intoJuliaPy:masterfrom
marius311:custom_pycall_sysimage

Conversation

@marius311
Copy link
Copy Markdown
Contributor

The current sysimage just installs the latest PyCall from the registry. This adds a --pycall-env option which lets you bake in an existing one from any project you want,

$ python -m julia.sysimage --pycall-env . sys.so # take PyCall from the project in the current folder

I found this useful in my debugging / developing, and I think it'd be nice to have in the official repo.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 15, 2020

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.38%. Comparing base (25049e3) to head (302c314).
⚠️ Report is 83 commits behind head on master.

Files with missing lines Patch % Lines
src/julia/sysimage.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   87.48%   87.38%   -0.11%     
==========================================
  Files          39       39              
  Lines        2246     2251       +5     
==========================================
+ Hits         1965     1967       +2     
- Misses        281      284       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tkf
Copy link
Copy Markdown
Member

tkf commented Sep 16, 2020

Thanks! Yes, it'd be nice to have.

Can you add a test for this? You can put it in https://github.com/tkf/pyjulia/blob/pyjuliatester/src/julia/tests/test_sysimage.py

Also, I wonder if it makes sense to call --pycall-env something else. For example, it might be useful to list, e.g., PyPlot and Plots in such an environment (even though currently they are not get loaded). Maybe --sysimage-env? Though --pycall-env kinda still makes sense since we always have PyCall in it.

Other than that, it LTGM!

@mkitti
Copy link
Copy Markdown
Member

mkitti commented Nov 23, 2022

Did we ever add a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants