allow skipping derivative computations#180
Open
aplavin wants to merge 2 commits into
Open
Conversation
schillic
reviewed
May 29, 2024
Member
schillic
left a comment
schillic
left a comment
There was a problem hiding this comment.
Thanks, this makes sense. May I ask you to add two changes?
- Add a test for
df=nothing. - Update the docstring of
BranchAndBoundEnclosure(inalgorithms.jl) to explain thatdf=nothingis a valid input that skips the check.
Author
|
done |
schillic
approved these changes
May 30, 2024
schillic
reviewed
May 30, 2024
Member
schillic
left a comment
schillic
left a comment
There was a problem hiding this comment.
The test failed. Please check again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have some usecases where derivative is almost never useful for range enclosure, but takes the majority of calculations.
This PR makes it possible to pass
df = nothingand skip all derivative-related computations.