Skip to content

Add inhomogenous case for HLBS25#1046

Merged
schillic merged 10 commits into
masterfrom
add_inhomogenous_case
May 9, 2026
Merged

Add inhomogenous case for HLBS25#1046
schillic merged 10 commits into
masterfrom
add_inhomogenous_case

Conversation

@alecarraro
Copy link
Copy Markdown
Collaborator

No description provided.

@alecarraro alecarraro force-pushed the add_inhomogenous_case branch from 14748eb to bc0455e Compare March 7, 2026 09:56
@schillic schillic marked this pull request as draft March 7, 2026 10:49
@alecarraro alecarraro force-pushed the add_inhomogenous_case branch from f0e1b8b to 9a766bd Compare March 29, 2026 21:08
@schillic schillic marked this pull request as ready for review April 2, 2026 21:26
Copy link
Copy Markdown
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some minor suggestions.

Comment thread src/Initialization/init.jl
Comment thread test/algorithms/HLBS25.jl

@test_broken begin
sol = solve(prob, alg; T=T)
setrep(sol) <: SparsePolynomialZonotope
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this broken?

Comment thread src/Discretization/CorrectionHullMatrixZonotope.jl Outdated
Comment thread src/Discretization/CorrectionHullMatrixZonotope.jl Outdated
Comment thread src/Algorithms/HLBS25/common.jl Outdated
Comment thread src/Algorithms/HLBS25/IDgen.jl
Comment thread src/Algorithms/HLBS25/IDgen.jl Outdated
Comment thread src/Algorithms/HLBS25/IDgen.jl Outdated
Comment thread src/Algorithms/HLBS25/IDgen.jl Outdated
Comment thread src/Algorithms/HLBS25/IDgen.jl Outdated
alecarraro and others added 2 commits May 7, 2026 20:19
Co-authored-by: Christian Schilling <git@christianschilling.net>
Copy link
Copy Markdown
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the ambiguity.

@schillic schillic merged commit e6c31ca into master May 9, 2026
6 checks passed
@schillic schillic deleted the add_inhomogenous_case branch May 9, 2026 17:32
@schillic schillic restored the add_inhomogenous_case branch May 9, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants