Test coverage and formatting

Author: Affie

src/GraphsDFG/FactorGraphs/FactorGraphs.jl

@@ -173,7 +173,7 @@ function rem_vertex!(g::FactorGraph{T, V, F}, v::Integer) where {T, V, F}
 end
 
 function Graphs.rem_vertices!(g::FactorGraph{T, V, F}, vs::Vector{Int}) where {T, V, F}
-    for v in sort(vs, rev = true)
+    for v in sort(vs; rev = true)
         v in vertices(g) || continue
         lastv = nv(g)
 

src/entities/Error.jl

@@ -54,8 +54,8 @@ struct IdNotFoundError{T} <: Exception
     available::Vector{T}
 end
 
-IdNotFoundError(name::String, id::T) where T = IdNotFoundError(name, id, T[])
-IdNotFoundError(id::T) where T = IdNotFoundError("Node", id, T[])
+IdNotFoundError(name::String, id::T) where {T} = IdNotFoundError(name, id, T[])
+IdNotFoundError(id::T) where {T} = IdNotFoundError("Node", id, T[])
 
 function Base.showerror(io::IO, ex::IdNotFoundError)
     print(io, "IdNotFoundError: ", ex.name, " id '", ex.id, "' not found.")

test/testBlocks.jl

@@ -460,15 +460,20 @@ function VariablesandFactorsCRUD_SET!(fg, v1, v2, v3, f0, f1, f2)
     @test addVariable!(fg, v3) === v3
     @test addFactor!(fg, f2) === f2
 
-    @test deleteFactor!(fg, f2) == 1
+    @test deleteFactors!(fg, [getLabel(f2)]) == 1
+    @test addFactor!(fg, f2) === f2
+    @test deleteFactors!(fg; whereLabel = ==(string(getLabel(f2)))) == 1
+    @test deleteFactors!(fg; whereLabel = ==("doesnotexist")) == 0
+
+    @test addFactor!(fg, f2) === f2
+    @test deleteVariables!(fg, [getLabel(v3)]) == 2
+    @test addVariable!(fg, v3) === v3
+    @test deleteVariables!(fg; whereLabel = ==(string(getLabel(v3)))) == 1
+    @test deleteVariables!(fg; whereLabel = ==("doesnotexist")) == 0
+
     @test deleteFactor!(fg, f2) == 0
     @test lsf(fg) == [:abf1]
 
-    delvarCompare = getVariable(fg, :c)
-    delfacCompare = []
-    ndel = deleteVariable!(fg, v3)
-    @test ndel == 1
-
     @test getVariable(fg, :a) == v1
 
     @test addFactor!(fg, f0) == f0