updateBlob! is obsolete

Author: Affie

src/DataBlobs/services/BlobStores.jl

@@ -76,14 +76,6 @@ end
 # also creates an blobid as uuid4
 addBlob!(store::AbstractBlobstore, data) = addBlob!(store, uuid4(), data)
 
-#update
-function updateBlob!(dfg::AbstractDFG, entry::Blobentry, data)
-    return updateBlob!(getBlobstore(dfg, entry.blobstore), entry.blobid, data)
-end
-
-function updateBlob!(store::AbstractBlobstore, entry::Blobentry, data)
-    return updateBlob!(store, entry.blobid, data)
-end
 #delete
 function deleteBlob!(dfg::AbstractDFG, entry::Blobentry)
     return deleteBlob!(getBlobstore(dfg, entry.blobstore), entry)
@@ -171,10 +163,6 @@ function addBlob!(store::FolderStore{T}, blobid::UUID, data::T) where {T}
     end
 end
 
-function updateBlob!(store::FolderStore{T}, blobid::UUID, data::T) where {T}
-    return error("updateBlob! is obsolete as blobid=>Blob pairs are immutable.")
-end
-
 function deleteBlob!(store::FolderStore{T}, blobid::UUID) where {T}
     # Tombstone pattern: instead of deleting the file, create a tombstone marker file
     blobfilename = joinpath(store.folder, string(store.label), string(blobid))
@@ -243,13 +231,6 @@ function addBlob!(store::InMemoryBlobstore{T}, blobid::UUID, data::T) where {T}
     return blobid
 end
 
-function updateBlob!(store::InMemoryBlobstore{T}, blobid::UUID, data::T) where {T}
-    if haskey(store.blobs, blobid)
-        @warn "Key '$blobid' doesn't exist."
-    end
-    return store.blobs[blobid] = data
-end
-
 function deleteBlob!(store::InMemoryBlobstore, blobid::UUID)
     if !haskey(store.blobs, blobid)
         throw(IdNotFoundError("Blob", blobid))

src/Deprecated.jl

@@ -344,6 +344,10 @@ function getFactorState(args...)
     )
 end
 
+function updateBlob!(args...)
+    return error("updateBlob! is obsolete as blobid=>Blob pairs are immutable.")
+end
+
 ## ================================================================================
 ## Deprecated in v0.28
 ##=================================================================================

src/DistributedFactorGraphs.jl

@@ -427,8 +427,6 @@ const unstable_functions::Vector{Symbol} = [
     :mergeGraph!,
     :buildSubgraph,
     :incrDataLabelSuffix,# TODO somewhat used, do we deprecate?
-    :updateMetadata!,## TODO deprecated or obsolete
-    :updateBlob!,## TODO deprecated or obsolete
 
     # set # TODO what to do here, maybe `ref` verb + setproperty.  
     :setSolverParams!,
@@ -440,6 +438,8 @@ const unstable_functions::Vector{Symbol} = [
     # no set on these
 
     #deprecated in v0.29
+    :updateMetadata!,## TODO deprecated or obsolete
+    :updateBlob!,## TODO deprecated or obsolete
     :getFactorState, # FIXME getFactorState were questioned and being reviewed again for name, other than that they are checked.
     :packDistribution,
     :unpackDistribution,