Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: Affie

src/GraphsDFG/GraphsDFG.jl

@@ -83,7 +83,7 @@ function DFG.rebuildFactorCache!(
     neighbors = [],
 )
     @warn(
-        "FactorCache not build, rebuildFactorCache! is not implemented for $(typeof(dfg)). `rebuildFactorCache!` is available in IncrementalInference.",
+        "FactorCache not built, rebuildFactorCache! is not implemented for $(typeof(dfg)). `rebuildFactorCache!` is available in IncrementalInference.",
         maxlog = 1
     )
     return nothing

src/GraphsDFG/services/GraphsDFG.jl

@@ -106,7 +106,7 @@ function mergeFactor!(dfg::GraphsDFG, factor::AbstractGraphFactor)
             ),
         )
     else
-        dfg.g.factors[factor.label] = factor
+        dfg.g.factors[label] = factor
     end
 
     return 1
@@ -268,7 +268,7 @@ function listNeighborhood(
     if !isnothing(solvable)
         Base.depwarn(
             "solvable kwarg is deprecated, use kwarg `solvableFilter = (>=solvable)` instead", #v0.29
-            :listNeighbors,
+            :listNeighborhood,
         )
         !isnothing(solvableFilter) &&
             error("Cannot use both solvable and solvableFilter kwargs.")

src/services/AbstractDFG.jl

@@ -346,7 +346,7 @@ Implement `listNeighbors(dfg::AbstractDFG, label::Symbol; solvableFilter, tagsFi
 function listNeighbors end
 
 function listNeighbors(dfg::AbstractDFG, node::AbstractGraphNode; kwargs...)
-    return listNeighbors(dfg, node.label; kwargs...)
+    return listNeighbors(dfg, getLabel(node); kwargs...)
 end
 ##------------------------------------------------------------------------------
 ## copy and duplication
@@ -587,7 +587,7 @@ Build a list of all unique neighbors inside 'distance'. Neighbors can be filtere
 Filters are applied to final neighborhood result.
 
 Notes
-- Returns `Vector{Symbol}`
+- Returns a tuple `(variableLabels, factorLabels)`, where each element is a `Vector{Symbol}`.
 
 Related:
 - [`copyGraph!`](@ref)
@@ -663,7 +663,7 @@ function buildSubgraph(
     if !isnothing(solvable)
         Base.depwarn(
             "solvable kwarg is deprecated, use kwarg `solvableFilter = (>=solvable)` instead", #v0.29
-            :listNeighbors,
+            :buildSubgraph,
         )
         !isnothing(solvableFilter) &&
             error("Cannot use both solvable and solvableFilter kwargs.")