Skip to content

deps bump ManifoldsBase to include v1 #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dehann merged 3 commits into from
May 6, 2025
Merged

deps bump ManifoldsBase to include v1 #1130

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9f5714
deps manifoldbase 1
dehann May 5, 2025
5591d1e
bump v0.25.5
dehann May 5, 2025
91dcd64
bump minor v0.26.0
dehann May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Project.toml
View file
Open in desktop
Copy link
Copy Markdown
Member

@Affie Affie May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next DFG should be v0.26.0 if I’m not mistaken.

Copy link
Copy Markdown
Member Author

@dehann dehann May 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @Affie, It should be fine to do a patch release. Not sure why #1128 is labelled breaking change if there are no changes to exports? Only a few other small PRs merged without breaking changes.

Also, I need a patch fix to restore all the repos for stable so trying to make it work before any real breaking changes like 1127 happen...

Copy link
Copy Markdown
Member Author

@dehann dehann May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess you mean user needs a new package and therefore a minor release. That's probably better -- I'll just release as v0.26.0 then.

Copy link
Copy Markdown
Member

@Affie Affie May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. See news.md using GraphPlot -> using GraphMakie

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "DistributedFactorGraphs"
uuid = "b5cc3c7e-6572-11e9-2517-99fb8daf2f04"
version = "0.25.4"
version = "0.26.0"

[deps]
Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
Expand Down Expand Up @@ -56,8 +56,8 @@ Graphs = "1.4"
InteractiveUtils = "1.10"
JSON3 = "1"
LinearAlgebra = "1.10"
Manifolds = "0.9, 0.10"
ManifoldsBase = "0.14, 0.15, 1"
Manifolds = "0.10"
ManifoldsBase = "0.15, 1"
OrderedCollections = "1.4"
Pkg = "1.4, 1.5"
ProgressMeter = "1"
Expand Down
Loading