Skip to content

Consolidate FactorDFG with FactorCompute, and rebuild Factor serialization.#1192

Merged
Affie merged 3 commits intodevelopfrom
refactor/factor
Nov 10, 2025
Merged

Consolidate FactorDFG with FactorCompute, and rebuild Factor serialization.#1192
Affie merged 3 commits intodevelopfrom
refactor/factor

Conversation

@Affie
Copy link
Copy Markdown
Member

@Affie Affie commented Nov 10, 2025

Towards #1179

@Affie Affie self-assigned this Nov 10, 2025
@Affie Affie added this to the v0.29.0 milestone Nov 10, 2025
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

"VariableCompute{TestVariableType1, Vector{Float64}, 1}\nid:\nnothing\nlabel:\n:a\ntags:\nSet([:VARIABLE, :POSE])\nsmallData:\nDict{Symbol, Union{Bool, Float64, Int64, Vector{Bool}, Vector{Float64}, Vector{Int64}, Vector{String}, String}}()\ndataDict:\nDict{Symbol, Blobentry}()\nsolvable:\nRefValue{Int64}(0)\n"
# "VariableCompute{TestVariableType1, Vector{Float64}, 1}\nid:\nnothing\nlabel:\n:a\ntags:\nSet([:VARIABLE, :POSE])\nsmallData:\nDict{Symbol, Union{Bool, Float64, Int64, Vector{Bool}, Vector{Float64}, Vector{Int64}, Vector{String}, String}}(:small=>\"data\")\ndataDict:\nDict{Symbol, Blobentry}()\nsolvable:\n0\n"


[JuliaFormatter] reported by reviewdog 🐶

@test fact.variableorder ==
getFactor(dfg, fact.label).variableorder

@Affie Affie added refactor standardization observation `FactorObservation` related, eg. Pose2Pose2 labels Nov 10, 2025
@Affie Affie merged commit b59f877 into develop Nov 10, 2025
1 of 3 checks passed
@Affie Affie deleted the refactor/factor branch November 10, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant