Skip to content

Bump compat for GeometryBasics, MeshCat, Mux, and OrderedCollections#66

Merged
rdeits merged 3 commits into
JuliaRobotics:masterfrom
ferrolho:hf/compat
Jan 4, 2022
Merged

Bump compat for GeometryBasics, MeshCat, Mux, and OrderedCollections#66
rdeits merged 3 commits into
JuliaRobotics:masterfrom
ferrolho:hf/compat

Conversation

@ferrolho

@ferrolho ferrolho commented Dec 1, 2021

Copy link
Copy Markdown
Member

No description provided.

@ferrolho

Copy link
Copy Markdown
Member Author

The CI tests for this PR are failing because they require JuliaRobotics/MechanismGeometries.jl#31 to be merged and also MechanismGeometries.jl v0.7.0 to be tagged.

@ferrolho

ferrolho commented Dec 20, 2021

Copy link
Copy Markdown
Member Author

Hmm, I believe the problem is now due to RigidBodyDynamics.jl not being up-to-date. However, this is a chicken-and-egg kind of situation, because JuliaRobotics/RigidBodyDynamics.jl#629 requires this MeshCatMechanisms.jl PR.

Btw, the reason why the tests fail on JuliaRobotics/RigidBodyDynamics.jl#629 (at least on my local machine) is because of the notebook tests, not the library itself. I have updated each notebooks' manifest, but some of them (e.g., notebook 4) can't resolve MeshCat v0.14 because that would require this MeshCatMechanisms.jl PR.

Comment thread Project.toml Outdated
MeshCat = "0.13"
Mux = "0.7.1"
MeshCat = "0.13, 0.14"
Mux = "0.7"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need the 0.7.1 here since there was some issue with 0.7

@rdeits

rdeits commented Dec 20, 2021

Copy link
Copy Markdown
Collaborator

Ok, makes sense. I'm fine with merging this to unblock things once the mux compat is resolved

@rdeits rdeits merged commit 48db720 into JuliaRobotics:master Jan 4, 2022
@ferrolho ferrolho deleted the hf/compat branch January 4, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants