Update breakage: use organization-wide workflow#80
Update breakage: use organization-wide workflow#80MaxenceGollier wants to merge 3 commits intoJuliaSmoothOptimizers:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Switches the repository’s breakage checking to use organization-wide reusable GitHub Actions workflows (per JuliaSmoothOptimizers/.github#18), removing the previously in-repo implementation.
Changes:
- Replaced the existing breakage workflow implementation with a call to
JuliaSmoothOptimizers/.githubreusable workflow. - Added a
workflow_run-triggered workflow to post breakage results/comments using an org-wide reusable workflow. - Removed the local
.breakageJulia project and script previously used to compute dependents.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/Breakage.yml |
Replaced local Breakage job graph with a reusable workflow call. |
.github/workflows/CommentBreakage.yml |
Added reusable workflow call to comment on PRs after Breakage completes. |
.breakage/get_jso_users.jl |
Removed (no longer needed with org-wide workflow). |
.breakage/Project.toml |
Removed (no longer needed with org-wide workflow). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| workflows: ["Breakage"] | ||
| types: | ||
| - completed | ||
|
|
There was a problem hiding this comment.
The called reusable workflow likely needs to download artifacts from the triggering Breakage run and post a PR comment. Because reusable workflows cannot increase GITHUB_TOKEN permissions beyond what the caller grants, this workflow should explicitly set appropriate top-level permissions (e.g., pull-requests: write and actions: read, plus contents: read) to avoid failures in repos where the default token permission is read-only.
| permissions: | |
| contents: read | |
| actions: read | |
| pull-requests: write |
There was a problem hiding this comment.
I don't understand this comment.
Following JuliaSmoothOptimizers/.github#18.