Skip to content

Update breakage: use organization-wide workflow#80

Open
MaxenceGollier wants to merge 3 commits intoJuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage
Open

Update breakage: use organization-wide workflow#80
MaxenceGollier wants to merge 3 commits intoJuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage

Conversation

@MaxenceGollier
Copy link
Copy Markdown

Copilot AI review requested due to automatic review settings April 27, 2026 13:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Switches the repository’s breakage checking to use organization-wide reusable GitHub Actions workflows (per JuliaSmoothOptimizers/.github#18), removing the previously in-repo implementation.

Changes:

  • Replaced the existing breakage workflow implementation with a call to JuliaSmoothOptimizers/.github reusable workflow.
  • Added a workflow_run-triggered workflow to post breakage results/comments using an org-wide reusable workflow.
  • Removed the local .breakage Julia project and script previously used to compute dependents.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/Breakage.yml Replaced local Breakage job graph with a reusable workflow call.
.github/workflows/CommentBreakage.yml Added reusable workflow call to comment on PRs after Breakage completes.
.breakage/get_jso_users.jl Removed (no longer needed with org-wide workflow).
.breakage/Project.toml Removed (no longer needed with org-wide workflow).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/CommentBreakage.yml
Comment thread .github/workflows/Breakage.yml
Comment thread .github/workflows/Breakage.yml Outdated
workflows: ["Breakage"]
types:
- completed

Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The called reusable workflow likely needs to download artifacts from the triggering Breakage run and post a PR comment. Because reusable workflows cannot increase GITHUB_TOKEN permissions beyond what the caller grants, this workflow should explicitly set appropriate top-level permissions (e.g., pull-requests: write and actions: read, plus contents: read) to avoid failures in repos where the default token permission is read-only.

Suggested change
permissions:
contents: read
actions: read
pull-requests: write

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants