Update breakage: use organization-wide workflow#170
Open
MaxenceGollier wants to merge 3 commits intoJuliaSmoothOptimizers:mainfrom
Open
Update breakage: use organization-wide workflow#170MaxenceGollier wants to merge 3 commits intoJuliaSmoothOptimizers:mainfrom
MaxenceGollier wants to merge 3 commits intoJuliaSmoothOptimizers:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s breakage checking setup to rely on organization-wide reusable GitHub Actions workflows (per JuliaSmoothOptimizers/.github#18).
Changes:
- Replace the in-repo Breakage workflow implementation with a reusable workflow call.
- Add a workflow-run triggered job to post/update breakage results via the org-wide comment workflow.
- Remove now-unused local
.breakagetooling (script + Project.toml).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/CommentBreakage.yml |
Adds a workflow that triggers on Breakage completion and delegates PR commenting to the org reusable workflow. |
.github/workflows/Breakage.yml |
Replaces the old matrix/build/test/comment logic with an org reusable workflow invocation. |
.breakage/get_jso_users.jl |
Removes obsolete script previously used to compute dependent packages. |
.breakage/Project.toml |
Removes obsolete dependencies for the deleted .breakage script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Hi @MaxenceGollier ! Thanks for this, I think copilot's comments are valid for this PR and the others as well. Thanks |
Author
|
Ha, i didn't catch this. Thanks for the comment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following JuliaSmoothOptimizers/.github#18.