Skip to content

Update breakage: use organization-wide workflow#110

Merged
tmigot merged 2 commits into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage
May 8, 2026
Merged

Update breakage: use organization-wide workflow#110
tmigot merged 2 commits into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage

Conversation

@MaxenceGollier
Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings April 28, 2026 15:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s breakage-check automation to use the organization-wide reusable workflows (per JuliaSmoothOptimizers/.github#18), replacing the previously in-repo implementation.

Changes:

  • Replace the full local Breakage workflow implementation with a call to the org reusable workflow.
  • Add a CommentBreakage workflow that runs on workflow_run to post results via the org reusable workflow.
  • Remove the local .breakage Julia helper script and its Project.toml since that logic is now handled upstream.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/Breakage.yml Switched to org reusable workflow for running breakage checks.
.github/workflows/CommentBreakage.yml New workflow to comment breakage results using org reusable workflow on workflow_run.
.breakage/get_jso_users.jl Removed local dependency-discovery script now superseded by org workflow.
.breakage/Project.toml Removed local breakage workflow dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

workflows: ["Breakage"]
types:
- completed

Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CommentBreakage triggers a workflow that (presumably) writes a PR comment, but this workflow doesn’t declare any explicit permissions. If the repo’s default GITHUB_TOKEN permission is set to read-only, the reusable workflow won’t be able to create/update PR comments. Add an explicit permissions: block (e.g., issues: write and/or pull-requests: write, plus contents: read if needed) at the workflow level so the called workflow can function reliably while staying least-privilege.

Suggested change
permissions:
contents: read
issues: write
pull-requests: write

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine because we run on workflow_run I think.

Comment thread .github/workflows/CommentBreakage.yml Outdated
@tmigot tmigot merged commit 3360bbe into JuliaSmoothOptimizers:main May 8, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants