Skip to content

Commit b35dcf6

Browse files
authored
Remove tests that are duplicate from SolverTest - Fix docs (#336)
* Remove tests that are duplicate from SolverTest
1 parent 815e89b commit b35dcf6

9 files changed

Lines changed: 7 additions & 86 deletions

File tree

docs/src/benchmark.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
## CUTEst benchmark
44

55
With JSO-compliant solvers, we can run the solver on a set of problems, explore the results, and compare to other JSO-compliant solvers using specialized benchmark tools.
6-
We are following here the tutorial in [SolverBenchmark.jl](https://jso.dev/SolverBenchmark.jl/stable) to run benchmarks on JSO-compliant solvers.
6+
We are following here the tutorial in [SolverBenchmark.jl](https://jso.dev/SolverBenchmark.jl/stable/) to run benchmarks on JSO-compliant solvers.
77

88
``` @example ex1
99
using CUTEst

docs/src/examples.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# Examples
22

3-
Beyond this repository's documentation, you can also find a list of tutorials on [JuliaSmoothOptimizers Tutorials](https://jso.dev/tutorials) by selecting the tag `JSOSolvers.jl`. For instance, the tutorial [Introduction to JSOSolvers](https://jso.dev/tutorials/introduction-to-jsosolvers/#title) is a good starting point.
3+
Beyond this repository's documentation, you can also find a list of tutorials on [JuliaSmoothOptimizers Tutorials](https://jso.dev/tutorials/) by selecting the tag `JSOSolvers.jl`. For instance, the tutorial [Introduction to JSOSolvers](https://jso.dev/tutorials/introduction-to-jsosolvers/#title) is a good starting point.
44

docs/src/performance-tips.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ stats = GenericExecutionStats(nlp) # pre-allocate output structure
1515
using JSOSolvers
1616
solver = TronSolver(nlp) # pre-allocate workspace
1717
SolverCore.solve!(solver, nlp, stats) # call tron in place
18-
JSOSolvers.reset!(solver)
18+
SolverCore.reset!(solver)
1919
NLPModels.reset!(nlp) # reset counters
2020
(@allocated SolverCore.solve!(solver, nlp, stats)) == 0
2121

src/tron.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ The keyword arguments may include
7979
- `verbose::Int = 0`: if > 0, display iteration details every `verbose` iteration.
8080
- `subsolver_verbose::Int = 0`: if > 0, display iteration information every `subsolver_verbose` iteration of the subsolver.
8181
82-
The keyword arguments of `TronSolver` are passed to the [`TRONTrustRegion`](https://jso.dev/SolverTools.jl/stable/reference/#SolverTools.TRONTrustRegion) constructor.
82+
The keyword arguments of `TronSolver` are passed to the [`TRONTrustRegion`](https://jso.dev/SolverTools.jl/stable/95-reference/#SolverTools.TRONTrustRegion) constructor.
8383
8484
# Output
8585
The value returned is a `GenericExecutionStats`, see `SolverCore.jl`.

src/tronls.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ The keyword arguments may include
8080
- `verbose::Int = 0`: if > 0, display iteration details every `verbose` iteration.
8181
- `subsolver_verbose::Int = 0`: if > 0, display iteration information every `subsolver_verbose` iteration of the subsolver.
8282
83-
The keyword arguments of `TronSolverNLS` are passed to the [`TRONTrustRegion`](https://jso.dev/SolverTools.jl/stable/reference/#SolverTools.TRONTrustRegion) constructor.
83+
The keyword arguments of `TronSolverNLS` are passed to the [`TRONTrustRegion`](https://jso.dev/SolverTools.jl/stable/95-reference/#SolverTools.TRONTrustRegion) constructor.
8484
8585
# Output
8686
The value returned is a `GenericExecutionStats`, see `SolverCore.jl`.

test/runtests.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@ include("restart.jl")
8484
include("callback.jl")
8585
include("consistency.jl")
8686
include("test_solvers.jl")
87+
include("incompatible.jl")
88+
8789
if VERSION v"1.7"
8890
include("allocs.jl")
8991

test/solvers/tronls.jl

Lines changed: 0 additions & 38 deletions
This file was deleted.

test/solvers/trunkls.jl

Lines changed: 0 additions & 40 deletions
This file was deleted.

test/test_solvers.jl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,3 @@ function tests()
6060
end
6161

6262
tests()
63-
64-
include("solvers/trunkls.jl")
65-
include("incompatible.jl")

0 commit comments

Comments
 (0)