Check that all parameters in parameter set work (#309)

* add parameter test

* format

* Update test/runtests.jl

Author: tmigot

src/trunk.jl

@@ -172,10 +172,19 @@ end
   ::Val{:Newton},
   nlp::AbstractNLPModel;
   x::V = nlp.meta.x0,
+  bk_max::Int = get(TRUNK_bk_max, nlp),
+  monotone::Bool = get(TRUNK_monotone, nlp),
+  nm_itmax::Int = get(TRUNK_nm_itmax, nlp),
   subsolver::Symbol = :cg,
   kwargs...,
 ) where {V}
-  solver = TrunkSolver(nlp; subsolver)
+  solver = TrunkSolver(
+    nlp;
+    bk_max = bk_max,
+    monotone = monotone,
+    nm_itmax = nm_itmax,
+    subsolver = subsolver,
+  )
   return solve!(solver, nlp; x = x, kwargs...)
 end
 

src/trunkls.jl

@@ -206,10 +206,19 @@ end
   ::Val{:GaussNewton},
   nlp::AbstractNLSModel;
   x::V = nlp.meta.x0,
+  bk_max::Int = get(TRUNKLS_bk_max, nlp),
+  monotone::Bool = get(TRUNKLS_monotone, nlp),
+  nm_itmax::Int = get(TRUNKLS_nm_itmax, nlp),
   subsolver::Symbol = :lsmr,
   kwargs...,
 ) where {V}
-  solver = TrunkSolverNLS(nlp; subsolver)
+  solver = TrunkSolverNLS(
+    nlp;
+    bk_max = bk_max,
+    monotone = monotone,
+    nm_itmax = nm_itmax,
+    subsolver = subsolver,
+  )
   return solve!(solver, nlp; x = x, kwargs...)
 end
 

test/runtests.jl

@@ -3,11 +3,41 @@ using Printf, LinearAlgebra, Logging, SparseArrays, Test
 
 # additional packages
 using ADNLPModels, LinearOperators, NLPModels, NLPModelsModifiers, SolverCore, SolverTools
-using NLPModelsTest
+using NLPModelsTest, SolverParameters
 
 # this package
 using JSOSolvers
 
+@testset "Test parameterset" begin
+  @testset "Test unconstrained parameters $paramset" for (paramset, fun) in (
+    (LBFGSParameterSet, lbfgs),
+    (TRONParameterSet, tron),
+    (TRUNKParameterSet, trunk),
+    (FOMOParameterSet, fomo),
+  )
+    nlp = BROWNDEN()
+    params = eval(paramset)(nlp)
+    args = Dict(
+      sym => SolverParameters.value(getfield(params, sym)) for sym in fieldnames(typeof(params))
+    )
+    stats = fun(nlp; args...)
+    @test stats.status == :first_order
+  end
+
+  @testset "Test unconstrained NLS parameters $paramset" for (paramset, fun) in (
+    (TRONLSParameterSet, tron),
+    (TRUNKLSParameterSet, trunk),
+  )
+    nls = MGH01()
+    params = eval(paramset)(nls)
+    args = Dict(
+      sym => SolverParameters.value(getfield(params, sym)) for sym in fieldnames(typeof(params))
+    )
+    stats = fun(nls; args...)
+    @test stats.status == :first_order
+  end
+end
+
 @testset "Test small residual checks $solver" for solver in (:TrunkSolverNLS, :TronSolverNLS)
   nls = ADNLSModel(x -> [x[1] - 1; sin(x[2])], [-1.2; 1.0], 2)
   stats = GenericExecutionStats(nls)