Skip to content

JOSS paper review comments #343

Description

@nkrusch

I have the following comments about the paper - ref: #9467.

Line numbers refer to paper.md (not rendered draft).

  • L43: missing space after Percival.jl, before bracket.

  • L49: Using "latter" for more than two items; consider re-wording (it is confusing which solver latter refers to).

  • L61: TRUNK-NLS first appears here (what is it?); consider introducing earlier (for example, around paragraph L48-53).

  • L77, 87, 95-98, 101: mixed case of IPOPT vs. Ipopt: I am confused by the different capitalization styles.
    If mixed case is necessary, it should at least be used consistently (say, to separate theory vs. implementation).
    E.g., At L77 "Solver like IPOPT" and L101 "Ipopt ... solver" presumably refer to the same solver?

  • L87: Perhaps missing a noun here: "Ipopt is widely used and efficient but requires explicit derivatives...".
    Compare: "Ipopt is a widely used and efficient solver, but requires explicit derivatives...".

  • Benchmarking: what kind of machine was used here (architecture, GPU/CPU, memory, cores)?
    This can be in a footnote, but it should be somewhere, to make sense of the reported times.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions