Skip to content

Fix JOSS paper review comments#346

Merged
tmigot merged 6 commits into
joss-paper-branchfrom
tmigot-patch-1
Jan 14, 2026
Merged

Fix JOSS paper review comments#346
tmigot merged 6 commits into
joss-paper-branchfrom
tmigot-patch-1

Conversation

@tmigot

@tmigot tmigot commented Jan 11, 2026

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Jan 11, 2026

Copy link
Copy Markdown
Contributor
Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

tmigot
tmigot commented Jan 13, 2026
View reviewed changes
Comment thread paper/paper.md Outdated
tmigot
tmigot commented Jan 13, 2026
View reviewed changes
Comment thread paper/paper.md Outdated
@github-actions

github-actions Bot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor
Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

@github-actions

github-actions Bot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor
Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

@github-actions

github-actions Bot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor
Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

@tmigot

tmigot commented Jan 13, 2026

Copy link
Copy Markdown
Member Author

Dear @nkrusch,
Thanks for the valuable comments and catching some disreptancies.
This PR should cover the comments in both issues #343 and #344.
Can you please let me know if you have any comment on this ?

Very sorry for the delay, it took us some time to understand how the Zenodo notice was created and realized there was a conflict between our use of CITATION.cff and an old .zenodo.json. It should be good now.

You will notice that we decided to remove the following reference:
Migot, T., Orban, D., Soares Siqueira, A., & contributors. (2024). JuliaSmoothOptimizers
but instead use only a footnote refering to the organization website.

I also took the liberty to add a missing ORCID number in the authors.

You can visualize the draft here: https://github.com/JuliaSmoothOptimizers/JSOSolvers.jl/actions/runs/20973988110

This was linked to issues Jan 13, 2026
JOSS paper review comments #343
Closed
JOSS paper bibliography review comments #344
Closed
@github-actions

github-actions Bot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor
Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

@github-actions

github-actions Bot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor
Package name latest stable
FletcherPenaltySolver
JSOSuite
PartiallySeparableNLPModels
Percival

This was referenced Jan 14, 2026
Closed
Closed
@nkrusch

nkrusch commented Jan 14, 2026

Copy link
Copy Markdown

@tmigot - thanks! I have checked the changes, and everything is addressed. Please merge.

@tmigot tmigot merged commit 138d120 into joss-paper-branch Jan 14, 2026
22 of 24 checks passed
@tmigot tmigot deleted the tmigot-patch-1 branch January 14, 2026 08:37
nkrusch
nkrusch reviewed Jan 14, 2026
View reviewed changes

@nkrusch nkrusch left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the compiled paper; all issues were addressed.

tmigot added a commit that referenced this pull request Jan 14, 2026
@tmigot
Fix JOSS paper review comments (#346)
503516b 
* Update metadata and summary in paper.md

* Update paper.bib

* Update metadata and summary in paper.md

* Update paper/paper.md

* Update paper/paper.md

* Update paper metadata and summary content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@nkrusch nkrusch nkrusch left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JOSS paper bibliography review comments JOSS paper review comments

2 participants

@tmigot @nkrusch