Fomo generalized#353
Open
d-monnet wants to merge 42 commits into
Open
Conversation
modified: src/fomo.jl remove useless vector p delete body of find_beta_tilde (TODO in next commit)
…vers.jl into fomo-generalized
tmigot
reviewed
Feb 11, 2026
|
|
||
| solver.α = init_alpha(norm_∇fk, step_backend) | ||
|
|
||
|
|
|
|
||
| grad!(nlp, x, g) | ||
| norm_∇fk = norm(g) | ||
| d .= -g |
Member
There was a problem hiding this comment.
does this allocate ? Should it be d .= .-g ?
Comment on lines
+648
to
+652
| """ | ||
| # function update_kappa(αk::T, αk₋::T, ::ia_momentum) where {T} | ||
| # 1 | ||
| # end | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| """ | |
| # function update_kappa(αk::T, αk₋::T, ::ia_momentum) where {T} | |
| # 1 | |
| # end | |
| """ |
Contributor
Author
|
Looks like the multiprec test fails because Test can be reproduced as Problem is solved with first order status on my machine, but |
* Update LICENSE.md to reflect MPL version 2.0
* Replace nightly by pre
* Add GPU test for TRUNK, TRUNK-NLS and FOMO * fix typo
* Add more information to the documentation * Delete 'How to cite' section from index.md Removed citation section from the documentation. * Update optimization problem notation in documentation Replaced LaTeX equation with plain text representation. * Fix formatting in documentation for JSOSolvers * add more * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix heading format in examples.md * Update docs/src/index.md * Update docs/src/index.md * Enhance documentation with function and algorithm details Added explanation of function properties and optimization methods. * Add header for doc in readme * Add unit test instructions for JSOSolvers package Added instructions for running unit tests for the JSOSolvers package. * Add unit test instructions to README Added instructions for running unit tests. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…thOptimizers#336) * Remove tests that are duplicate from SolverTest
…s#334) * Add deps and tests comment * Update docs/src/index.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * add-more-on-tests --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Improve doc * Update src/tronls.jl Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Move callback section to doc * fix
JOSS release for paper submission. This release corresponds to the version reviewed in the JOSS submission.
Fix the Zenodo release
…vers.jl into fomo-generalized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Nesterov's Heavy-Ball and non-linear conjugate gradient (Polak-Ribière and Fletcher-Reeves) momentum strategies.