-
Notifications
You must be signed in to change notification settings - Fork 10
Update breakage: use organization-wide workflow #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tmigot
merged 2 commits into
JuliaSmoothOptimizers:main
from
MaxenceGollier:update-breakage
Jun 6, 2026
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,165 +1,9 @@ | ||
| # Ref: https://securitylab.github.com/research/github-actions-preventing-pwn-requests | ||
| name: Breakage | ||
|
|
||
| # read-only repo token | ||
| # no access to secrets | ||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
|
|
||
| jobs: | ||
| # Build dynamically the matrix on which the "break" job will run. | ||
| # The matrix contains the packages that depend on ${{ env.pkg }}. | ||
| # Job "setup_matrix" outputs variable "matrix", which is in turn | ||
| # the output of the "getmatrix" step. | ||
| # The contents of "matrix" is a JSON description of a matrix used | ||
| # in the next step. It has the form | ||
| # { | ||
| # "pkg": [ | ||
| # "PROPACK", | ||
| # "LLSModels", | ||
| # "FletcherPenaltySolver" | ||
| # ] | ||
| # } | ||
| setup_matrix: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| matrix: ${{ steps.getmatrix.outputs.matrix }} | ||
| env: | ||
| pkg: ${{ github.event.repository.name }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: julia-actions/setup-julia@v2 | ||
| with: | ||
| version: 1 | ||
| arch: x64 | ||
| - id: getmatrix | ||
| run: | | ||
| julia -e 'using Pkg; Pkg.Registry.add(RegistrySpec(url = "https://github.com/JuliaRegistries/General.git"))' | ||
| julia --project=.breakage -e 'using Pkg; Pkg.update(); Pkg.instantiate()' | ||
| pkgs=$(julia --project=.breakage .breakage/get_jso_users.jl ${{ env.pkg }}) | ||
| vs='["latest", "stable"]' | ||
| # Check if pkgs is empty, and set it to a JSON array if necessary | ||
| if [[ -z "$pkgs" || "$pkgs" == "String[]" ]]; then | ||
| echo "No packages found; exiting successfully." | ||
| exit 0 | ||
| fi | ||
| vs='["latest", "stable"]' | ||
| matrix=$(jq -cn --argjson deps "$pkgs" --argjson vers "$vs" '{pkg: $deps, pkgversion: $vers}') # don't escape quotes like many posts suggest | ||
| echo "matrix=$matrix" >> "$GITHUB_OUTPUT" | ||
|
|
||
| break: | ||
| needs: setup_matrix | ||
| if: needs.setup_matrix.result == 'success' && needs.setup_matrix.outputs.matrix != '' | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: ${{ fromJSON(needs.setup_matrix.outputs.matrix) }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| # Install Julia | ||
| - uses: julia-actions/setup-julia@v2 | ||
| with: | ||
| version: 1 | ||
| arch: x64 | ||
| - uses: actions/cache@v4 | ||
| env: | ||
| cache-name: cache-artifacts | ||
| with: | ||
| path: ~/.julia/artifacts | ||
| key: ${{ runner.os }}-test-${{ env.cache-name }}-${{ hashFiles('**/Project.toml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-test-${{ env.cache-name }}- | ||
| ${{ runner.os }}-test- | ||
| ${{ runner.os }}- | ||
| - uses: julia-actions/julia-buildpkg@v1 | ||
|
|
||
| # Breakage test | ||
| - name: 'Breakage of ${{ matrix.pkg }}, ${{ matrix.pkgversion }} version' | ||
| env: | ||
| PKG: ${{ matrix.pkg }} | ||
| VERSION: ${{ matrix.pkgversion }} | ||
| run: | | ||
| set -v | ||
| mkdir -p ./breakage | ||
| git clone https://github.com/JuliaSmoothOptimizers/$PKG.jl.git | ||
| cd $PKG.jl | ||
| if [ $VERSION == "stable" ]; then | ||
| TAG=$(git tag -l "v*" --sort=-creatordate | head -n1) | ||
| if [ -z "$TAG" ]; then | ||
| TAG="no_tag" | ||
| else | ||
| git checkout $TAG | ||
| fi | ||
| else | ||
| TAG=$VERSION | ||
| fi | ||
| export TAG | ||
| julia -e 'using Pkg; | ||
| PKG, TAG, VERSION = ENV["PKG"], ENV["TAG"], ENV["VERSION"] | ||
| joburl = joinpath(ENV["GITHUB_SERVER_URL"], ENV["GITHUB_REPOSITORY"], "actions/runs", ENV["GITHUB_RUN_ID"]) | ||
| open("../breakage/breakage-$PKG-$VERSION", "w") do io | ||
| try | ||
| TAG == "no_tag" && error("No tag for $VERSION") | ||
| pkg"activate ."; | ||
| pkg"instantiate"; | ||
| pkg"dev ../"; | ||
| if TAG == "latest" | ||
| global TAG = chomp(read(`git rev-parse --short HEAD`, String)) | ||
| end | ||
| pkg"build"; | ||
| pkg"test"; | ||
|
|
||
| print(io, "[]($joburl)"); | ||
| catch e | ||
| @error e; | ||
| print(io, "[]($joburl)"); | ||
| end; | ||
| end' | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: breakage-${{ matrix.pkg }}-${{ matrix.pkgversion }} | ||
| path: breakage/breakage-* | ||
|
|
||
| upload: | ||
| needs: break | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| path: breakage | ||
| pattern: breakage-* | ||
| merge-multiple: true | ||
|
|
||
| - run: ls -R | ||
| - run: | | ||
| cd breakage | ||
| echo "| Package name | latest | stable |" > summary.md | ||
| echo "|--|--|--|" >> summary.md | ||
| count=0 | ||
| for file in breakage-* | ||
| do | ||
| if [ $count == "0" ]; then | ||
| name=$(echo $file | cut -f2 -d-) | ||
| echo -n "| $name | " | ||
| else | ||
| echo -n "| " | ||
| fi | ||
| cat $file | ||
| if [ $count == "0" ]; then | ||
| echo -n " " | ||
| count=1 | ||
| else | ||
| echo " |" | ||
| count=0 | ||
| fi | ||
| done >> summary.md | ||
|
|
||
| - name: PR comment with file | ||
| uses: thollander/actions-comment-pull-request@v2 | ||
| with: | ||
| filePath: breakage/summary.md | ||
| breakage: | ||
| uses: JuliaSmoothOptimizers/.github/.github/workflows/Breakage.yml@main | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| name: Comment Breakage | ||
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: ["Breakage"] | ||
| types: | ||
| - completed | ||
|
|
||
| jobs: | ||
| comment_pr: | ||
| uses: JuliaSmoothOptimizers/.github/.github/workflows/CommentBreakage.yml@main | ||
|
tmigot marked this conversation as resolved.
Outdated
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.