Add aqua workflow, fix related issues (#251)

* add aqua workflow, fix related issues

* Apply suggestions from code review

Co-authored-by: Alexis <35051714+amontoison@users.noreply.github.com>

Author: geoffroyleconte

.github/workflows/Aqua.yml

@@ -0,0 +1,17 @@
+name: Aqua
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    types: [opened, synchronize, reopened]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: julia-actions/setup-julia@latest
+        with:
+          version: '1'
+      - name: Aqua.jl
+        run: julia --color=yes -e 'using Pkg; Pkg.add("Aqua"); Pkg.develop(path="."); using Aqua, LinearOperators; Aqua.test_all(LinearOperators)'

src/special-operators.jl

@@ -17,6 +17,10 @@ struct opEye <: AbstractLinearOperator{Any} end
 *(x::AbstractArray{T, 1} where {T}, ::opEye) = x
 *(::opEye, A::AbstractArray{T, 2} where {T}) = A
 *(A::AbstractArray{T, 2} where {T}, ::opEye) = A
+*(
+  v::Union{LinearAlgebra.Adjoint{S, V}, LinearAlgebra.Transpose{S, V}},
+  ::LinearOperators.opEye,
+) where {S, V <: AbstractVector{S}} = v
 *(::opEye, T::AbstractLinearOperator) = T
 *(T::AbstractLinearOperator, ::opEye) = T
 *(::opEye, T::opEye) = T
@@ -212,9 +216,9 @@ opExtension(k::I, ncol::I) where {I <: Integer} = opExtension([k], ncol)
 import Base.getindex
 function getindex(
   op::AbstractLinearOperator,
-  rows::Union{LinearOperatorIndexType{I}, I, Colon},
-  cols::Union{LinearOperatorIndexType{I}, I, Colon},
-) where {I <: Integer}
+  rows::Union{LinearOperatorIndexType{<:Integer}, <:Integer, Colon},
+  cols::Union{LinearOperatorIndexType{<:Integer}, <:Integer, Colon},
+)
   R = opRestriction(rows, size(op, 1))
   E = opExtension(cols, size(op, 2))
   return R * op * E

test/test_linop.jl

@@ -223,6 +223,7 @@ function test_linop()
       @test(abs(norm(opI2 * v - v)) <= ϵ * norm(v))
       @test(abs(norm(transpose(opI) * v - v)) <= ϵ * norm(v))
       @test(abs(norm(opI' * v - v)) <= ϵ * norm(v))
+      @test(abs(norm(v' * opI - v')) <= ϵ * norm(v))
       @test(norm(Matrix(opI) - Matrix(1.0I, nrow, nrow)) <= ϵ * norm(Matrix(1.0I, nrow, nrow)))
 
       w = opI * v