Optimize computations in LBFGS#381
Merged
amontoison merged 3 commits intoJan 23, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
- Coverage 95.00% 94.13% -0.87%
==========================================
Files 17 20 +3
Lines 1100 1143 +43
==========================================
+ Hits 1045 1076 +31
- Misses 55 67 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dpo
approved these changes
Jan 12, 2026
Member
dpo
left a comment
dpo
left a comment
There was a problem hiding this comment.
Thank you. Are you observing a difference in terms of time?
Member
|
@MaxenceGollier All the tests are failing here. |
Contributor
Author
|
@dpo, yes but it's not due to my PR, they fail on compatibility errors though i don't add any dependency. |
amontoison
approved these changes
Jan 23, 2026
amontoison
merged commit f1e5ee9
into
JuliaSmoothOptimizers:main
46 of 57 checks passed
Member
|
For the record, I don’t think we should merge PRs while dependency checks are failing. Those should be fixed separately first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#378