Fix allocation issue on julia pre CI#402
Merged
amontoison merged 1 commit intoJuliaSmoothOptimizers:mainfrom Feb 21, 2026
Merged
Fix allocation issue on julia pre CI#402amontoison merged 1 commit intoJuliaSmoothOptimizers:mainfrom
amontoison merged 1 commit intoJuliaSmoothOptimizers:mainfrom
Conversation
Fixes allocation isse on julia pre
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the @wrappedallocs test helper macro to reduce CI flakiness in allocation checks (notably on Julia pre-release CI) by “warming up” the evaluated expression before measuring allocations.
Changes:
- Update
@wrappedallocsto evaluate the target expression once before running@allocatedon it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@MaxenceGollier I approved the workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 95.00% 95.36% +0.36%
==========================================
Files 17 21 +4
Lines 1100 1186 +86
==========================================
+ Hits 1045 1131 +86
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amontoison
approved these changes
Feb 21, 2026
amontoison
merged commit 40edb65
into
JuliaSmoothOptimizers:main
65 of 152 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see for example this run.
I think this should fix, @amontoison, can you approve the workflows and merge if it solves ?
We can merge #399 and #400 after.