Fix inferrability of size(::AdjTrans)#403
Merged
amontoison merged 1 commit intoJuliaSmoothOptimizers:mainfrom Feb 22, 2026
Merged
Fix inferrability of size(::AdjTrans)#403amontoison merged 1 commit intoJuliaSmoothOptimizers:mainfrom
size(::AdjTrans)#403amontoison merged 1 commit intoJuliaSmoothOptimizers:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a type inference issue in the size method for adjoint and transpose linear operators by replacing tuple indexing with the reverse function.
Changes:
- Replace
size(A)[[2; 1]]withreverse(size(A))forAdjTransoperators to enable better type inference by the Julia compiler
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amontoison
approved these changes
Feb 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
+ Coverage 95.00% 95.44% +0.44%
==========================================
Files 17 21 +4
Lines 1100 1186 +86
==========================================
+ Hits 1045 1132 +87
+ Misses 55 54 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0f71d74
into
JuliaSmoothOptimizers:main
60 of 61 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For tuples, the compiler can't infer the size of
t[[2; 1]]: