Define generic neval_hprod for QuasiNewtonModels (#144)

* Define generic neval_hprod for QuasiNewtonModels

supsersedes #102

Author: dpo

Project.toml

@@ -14,7 +14,7 @@ SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 FastClosures = "0.3.0"
 LinearAlgebra = "1.10"
 LinearOperators = "^2.7"
-NLPModels = "0.21.6"
+NLPModels = "0.21"
 Printf = "1.10"
 SparseArrays = "1.10"
 julia = "1.10"

src/quasi-newton.jl

@@ -29,6 +29,9 @@ function get_op(nlp::QuasiNewtonModel)
   error("get_op is not implemented for $(typeof(nlp)).")
 end
 
+# Redefine neval_hprod for all QuasiNewtonModels.
+NLPModels.neval_hprod(nlp::QuasiNewtonModel) = get_op(nlp).nprod
+
 mutable struct LBFGSModel{
   T,
   S,
@@ -45,7 +48,6 @@ end
 get_model(nlp::LBFGSModel) = nlp.model
 get_op(nlp::LBFGSModel) = nlp.op
 @default_counters LBFGSModel model (neval_hprod,)
-NLPModels.neval_hprod(nlp::LBFGSModel) = get_op(nlp).nprod
 
 mutable struct LSR1Model{
   T,
@@ -63,7 +65,6 @@ end
 get_model(nlp::LSR1Model) = nlp.model
 get_op(nlp::LSR1Model) = nlp.op
 @default_counters LSR1Model model (neval_hprod,)
-NLPModels.neval_hprod(nlp::LSR1Model) = get_op(nlp).nprod
 
 mutable struct DiagonalQNModel{
   T,
@@ -80,7 +81,6 @@ end
 get_model(nlp::DiagonalQNModel) = nlp.model
 get_op(nlp::DiagonalQNModel) = nlp.op
 @default_counters DiagonalQNModel model (neval_hprod,)
-NLPModels.neval_hprod(nlp::DiagonalQNModel) = get_op(nlp).nprod
 
 "Construct a `LBFGSModel` from another type of model."
 function LBFGSModel(nlp::AbstractNLPModel{T, S}; kwargs...) where {T, S}