Skip to content

Update show tests#133

Merged
amontoison merged 1 commit into
JuliaSmoothOptimizers:mainfrom
klamike:mk/update_jaclin
Jan 23, 2026
Merged

Update show tests#133
amontoison merged 1 commit into
JuliaSmoothOptimizers:mainfrom
klamike:mk/update_jaclin

Conversation

@klamike

@klamike klamike commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

Update for JuliaSmoothOptimizers/NLPModels.jl#500

Should only be merged upon the next release of NLPModels

Comment thread src/quasi-newton.jl
@klamike

klamike commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

I'll refactor so it's just the show test fixes (ref JuliaSmoothOptimizers/NLPModels.jl#500)

Copilot AI review requested due to automatic review settings December 5, 2025 22:17
@klamike klamike changed the title Update for NLPModels 0.22 Update show tests Dec 5, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates test expectations to be compatible with NLPModels 0.22, which introduces separate display of linear and nonlinear Jacobian non-zero counts in model output. The PR only modifies test files to reflect the new output format from NLPModels.

Key Changes:

  • Updated expected output strings in "Show" tests to include two new fields: lin_nnzj and nln_nnzj
  • These new fields display the counts of non-zero elements in the linear and nonlinear parts of the Jacobian separately
  • All changes maintain arithmetic consistency: lin_nnzj + nln_nnzj = nnzj

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/nls/slack-model.jl Added lin_nnzj and nln_nnzj lines to expected output (3 + 8 = 11)
test/nls/feasibility-residual.jl Added lin_nnzj and nln_nnzj lines with "------" placeholder for unconstrained case
test/nls/feasibility-form-nls.jl Added lin_nnzj and nln_nnzj lines to expected output (2 + 11 = 13)
test/nlp/slack-model.jl Added lin_nnzj and nln_nnzj lines to expected output (2 + 3 = 5)
test/nlp/quasi-newton.jl Added lin_nnzj and nln_nnzj lines to expected output (2 + 2 = 4)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@amontoison amontoison merged commit 5416ea9 into JuliaSmoothOptimizers:main Jan 23, 2026
30 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants