Update show tests#133
Merged
Merged
Conversation
klamike
commented
Nov 20, 2025
Contributor
Author
|
I'll refactor so it's just the |
1c9d822 to
3121467
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates test expectations to be compatible with NLPModels 0.22, which introduces separate display of linear and nonlinear Jacobian non-zero counts in model output. The PR only modifies test files to reflect the new output format from NLPModels.
Key Changes:
- Updated expected output strings in "Show" tests to include two new fields:
lin_nnzjandnln_nnzj - These new fields display the counts of non-zero elements in the linear and nonlinear parts of the Jacobian separately
- All changes maintain arithmetic consistency:
lin_nnzj + nln_nnzj = nnzj
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/nls/slack-model.jl | Added lin_nnzj and nln_nnzj lines to expected output (3 + 8 = 11) |
| test/nls/feasibility-residual.jl | Added lin_nnzj and nln_nnzj lines with "------" placeholder for unconstrained case |
| test/nls/feasibility-form-nls.jl | Added lin_nnzj and nln_nnzj lines to expected output (2 + 11 = 13) |
| test/nlp/slack-model.jl | Added lin_nnzj and nln_nnzj lines to expected output (2 + 3 = 5) |
| test/nlp/quasi-newton.jl | Added lin_nnzj and nln_nnzj lines to expected output (2 + 2 = 4) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5416ea9
into
JuliaSmoothOptimizers:main
30 of 45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for JuliaSmoothOptimizers/NLPModels.jl#500
Should only be merged upon the next release of NLPModels