Conversation
There was a problem hiding this comment.
Pull request overview
Defines a single, generic neval_hprod implementation for all QuasiNewtonModel wrappers, reducing per-type duplication and aligning counter behavior across the quasi-Newton models in this package (superseding #102).
Changes:
- Add
NLPModels.neval_hprod(::QuasiNewtonModel)implemented viaget_op(nlp).nprod. - Remove redundant
neval_hproddefinitions forLBFGSModel,LSR1Model, andDiagonalQNModel. - Broaden
NLPModelscompat from0.21.6to0.21.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/quasi-newton.jl |
Centralizes neval_hprod for all QuasiNewtonModel types and removes duplicated per-struct overrides. |
Project.toml |
Relaxes NLPModels compatibility constraint to allow the full 0.21.x range. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supsersedes #102