Skip to content

Commit 4dc1698

Browse files
committed
Fix #421: unify arglina/arglinb/arglinc behavior by removing public m from PureJuMP wrappers
1 parent 101e896 commit 4dc1698

3 files changed

Lines changed: 6 additions & 9 deletions

File tree

src/PureJuMP/arglina.jl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@
1212
export arglina
1313

1414
"Linear function with `n` parameters and `m` observations - full rank"
15-
function arglina(args...; n::Int = default_nvar, m::Int = 2n, kwargs...)
16-
m < n && @warn("arglina: must have m ≥ n")
17-
m = max(m, n)
15+
function arglina(args...; n::Int = default_nvar, kwargs...)
16+
m = 2 * n
1817

1918
nlp = Model()
2019

src/PureJuMP/arglinb.jl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@
1212
export arglinb
1313

1414
"Linear function with `n` parameters and `m` observations - rank 1"
15-
function arglinb(args...; n::Int = default_nvar, m::Int = 2n, kwargs...)
16-
m < n && @warn("arglinb: must have m ≥ n")
17-
m = max(m, n)
15+
function arglinb(args...; n::Int = default_nvar, kwargs...)
16+
m = 2 * n
1817

1918
nlp = Model()
2019

src/PureJuMP/arglinc.jl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@
1212
export arglinc
1313

1414
"Linear function with `n` parameters and `m` observations - rank 1, zero columns and rows"
15-
function arglinc(args...; n::Int = default_nvar, m::Int = 2n, kwargs...)
16-
m < n && @warn("arglinc: must have m ≥ n")
17-
m = max(m, n)
15+
function arglinc(args...; n::Int = default_nvar, kwargs...)
16+
m = 2 * n
1817

1918
nlp = Model()
2019

0 commit comments

Comments
 (0)