Skip to content

Commit 6cc8f9e

Browse files
authored
Fix #421: unify arglina/arglinb/arglinc behavior by removing public m from PureJuMP wrappers (#422)
1 parent e5ae91f commit 6cc8f9e

3 files changed

Lines changed: 6 additions & 9 deletions

File tree

src/PureJuMP/arglina.jl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
export arglina
22

33
"Linear function with `n` parameters and `m` observations - full rank"
4-
function arglina(args...; n::Int = default_nvar, m::Int = 2n, kwargs...)
5-
m < n && @warn("arglina: must have m ≥ n")
6-
m = max(m, n)
4+
function arglina(args...; n::Int = default_nvar, kwargs...)
5+
m = 2 * n
76

87
nlp = Model()
98

src/PureJuMP/arglinb.jl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
export arglinb
22

33
"Linear function with `n` parameters and `m` observations - rank 1"
4-
function arglinb(args...; n::Int = default_nvar, m::Int = 2n, kwargs...)
5-
m < n && @warn("arglinb: must have m ≥ n")
6-
m = max(m, n)
4+
function arglinb(args...; n::Int = default_nvar, kwargs...)
5+
m = 2 * n
76

87
nlp = Model()
98

src/PureJuMP/arglinc.jl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
export arglinc
22

33
"Linear function with `n` parameters and `m` observations - rank 1, zero columns and rows"
4-
function arglinc(args...; n::Int = default_nvar, m::Int = 2n, kwargs...)
5-
m < n && @warn("arglinc: must have m ≥ n")
6-
m = max(m, n)
4+
function arglinc(args...; n::Int = default_nvar, kwargs...)
5+
m = 2 * n
76

87
nlp = Model()
98

0 commit comments

Comments
 (0)