Fix calculation in trigb.jl for sine terms

arnavk23 · web-flow · commit c5f4c0039cbb · 2026-02-21T04:27:46.000+05:30
diff --git a/src/PureJuMP/trigb.jl b/src/PureJuMP/trigb.jl
@@ -20,7 +20,7 @@ function trigb(args...; n::Int = default_nvar, kwargs...)
     Min,
     sum(
       i *
-      ((1 - cos(x[i])) + ((i == 1) ? sin(0) : sin(x[i - 1])) - ((i == n) ? sin(0) : sin(x[i + 1])))
+      ((1 - cos(x[i])) + ((i == 1) ? sin(0) : sin(x[i - 1])) - ((i == n) ? 0 : sin(x[i + 1])))
       for i = 1:n
     )
   )

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ function trigb(args...; n::Int = default_nvar, kwargs...)`
`20`	`20`	`Min,`
`21`	`21`	`sum(`
`22`	`22`	`i *`
`23`		`- ((1 - cos(x[i])) + ((i == 1) ? sin(0) : sin(x[i - 1])) - ((i == n) ? sin(0) : sin(x[i + 1])))`
	`23`	`+ ((1 - cos(x[i])) + ((i == 1) ? sin(0) : sin(x[i - 1])) - ((i == n) ? 0 : sin(x[i + 1])))`
`24`	`24`	`for i = 1:n`
`25`	`25`	`)`
`26`	`26`	`)`