Problem 9,10 and 16#396
Merged
tmigot merged 25 commits intoJuliaSmoothOptimizers:mainfrom Feb 26, 2026
Merged
Conversation
Contributor
Author
|
@tmigot please review. On my system they are passing when I use one(T), T(i) and T(mod(i,5)). |
tmigot
requested changes
Nov 18, 2025
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Contributor
Author
|
@tmigot Worked on your review comments but now seeing |
tmigot
reviewed
Nov 18, 2025
tmigot
requested changes
Nov 23, 2025
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
tmigot
requested changes
Dec 16, 2025
There was a problem hiding this comment.
Pull request overview
This pull request adds three new optimization test problems (Problems 9, 10, and 16) from the Luksan, Matonoha, and Vlcek test problem collection. The implementation follows the established pattern for optimization problems in this repository, providing three variants: PureJuMP models, ADNLPProblems models, and metadata files.
Key Changes:
- Added three trigonometric optimization problems:
trig(Problem 9),toint(Problem 10), andtrigb(Problem 16) - Each problem is implemented in three formats: PureJuMP, ADNLPProblems, and metadata configurations
- All problems are unconstrained minimization problems with variable dimensions
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/PureJuMP/trig.jl | PureJuMP implementation of the "Another trigonometric function" problem (Problem 9) |
| src/PureJuMP/toint.jl | PureJuMP implementation of the "Toint trigonometric function" problem (Problem 10) |
| src/PureJuMP/trigb.jl | PureJuMP implementation of the "Banded trigonometric problem" (Problem 16) |
| src/ADNLPProblems/trig.jl | ADNLPProblems implementation of Problem 9 using automatic differentiation |
| src/ADNLPProblems/toint.jl | ADNLPProblems implementation of Problem 10 with critical bugs in division operators |
| src/ADNLPProblems/trigb.jl | ADNLPProblems implementation of Problem 16 |
| src/Meta/trig.jl | Metadata configuration for the trig problem |
| src/Meta/toint.jl | Metadata configuration for the toint problem |
| src/Meta/trigb.jl | Metadata configuration for the trigb problem |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
===========================================
- Coverage 99.80% 54.34% -45.47%
===========================================
Files 1084 1138 +54
Lines 12319 13371 +1052
===========================================
- Hits 12295 7266 -5029
- Misses 24 6105 +6081 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmigot
requested changes
Dec 19, 2025
tmigot
requested changes
Feb 20, 2026
tmigot
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#116
