Conversation
…gister and replace diffquot with inline exp expressions; convert hs61 to NonlinearExpr constraints to avoid legacy @nl usage
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
tmigot
left a comment
There was a problem hiding this comment.
@arnavk23 can you please pay more attention to your PR when you ask for the review?
I am making the same comments and the problem code does not match the screenshot you gave. There is obviously an error in the book as both sums have the same indices so please explain what you chose
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
===========================================
- Coverage 99.80% 54.53% -45.28%
===========================================
Files 1084 1129 +45
Lines 12319 13277 +958
===========================================
- Hits 12295 7240 -5055
- Misses 24 6037 +6013 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@tmigot Thank you for all your help. I found it very difficult to implement variational and thus ended up making a lot of mistakes (often the same one again and again :) ). I apologize if in the whole process I ever troubled you. I'll communicate better in the future if I face any such problem ( I just thought to tackle this head on this time). But all in all, thanks for being this patient with me and helping me learn. |
#116
