remove test from callback and add in test-solver instead

Author: MaxenceGollier

test/test-R2N.jl

@@ -43,10 +43,8 @@
     )
 
     callback = (nlp, solver, stats) -> begin
-      # Check that everything is well computed
-      @test all(solver.mν∇fk + solver.∇fk/stats.solver_specific[:sigma_cauchy] .≤ eps(eltype(solver.mν∇fk)))
-      # TODO: add a few tests here.
-
+      # We could add some tests here as well.
+      
       # Check user status
       if stats.iter == 4
         stats.status = :user

test/test-solver.jl

@@ -41,6 +41,7 @@ function test_solver(
   @test stats_optimized.status == expected_status
   @test obj(reg_nlp, stats_optimized.solution) == stats_optimized.objective
   @test stats_optimized.objective <= obj(reg_nlp, x0)
+  @test all(solver.mν∇fk + solver.∇fk/stats_optimized.solver_specific[:sigma_cauchy] .≤ eps(eltype(solver.mν∇fk)))
 
   # TODO: test that the optimized entries in stats_optimized and stats_basic are the same.