update SolverCore compat and add step_status#297
Merged
MaxenceGollier merged 1 commit intoJuliaSmoothOptimizers:masterfrom Feb 23, 2026
Merged
update SolverCore compat and add step_status#297MaxenceGollier merged 1 commit intoJuliaSmoothOptimizers:masterfrom
MaxenceGollier merged 1 commit intoJuliaSmoothOptimizers:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SolverCore dependency and adds step status tracking to regularization and trust-region optimization solvers. Following the upstream change in SolverCore.jl PR #130, users can now access the step acceptance status (:accepted, :rejected, or :unknown) through the stats object during callbacks and after solver completion.
Changes:
- Updated SolverCore compatibility from 0.3.0 to 0.3.10
- Added
set_step_status!(stats, :accepted)calls when steps are accepted (η1 ≤ ρk < Inf) in all relevant solver algorithms - Added
set_step_status!(stats, :rejected)calls when steps are rejected (ρk < η1 || ρk == Inf) in all relevant solver algorithms - Added test assertions to verify step_status field is properly set for all solver types
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Project.toml | Updated SolverCore compatibility requirement to version 0.3.10 |
| src/TR_alg.jl | Added step status tracking (accepted/rejected) based on reduction ratio ρk |
| src/TRDH_alg.jl | Added step status tracking (accepted/rejected) based on reduction ratio ρk |
| src/R2_alg.jl | Added step status tracking (accepted/rejected) based on reduction ratio ρk |
| src/R2N.jl | Added step status tracking (accepted/rejected) based on reduction ratio ρk |
| src/R2DH.jl | Added step status tracking (accepted/rejected) based on reduction ratio ρk |
| src/LM_alg.jl | Added step status tracking (accepted/rejected) based on reduction ratio ρk |
| src/LMTR_alg.jl | Added step status tracking (accepted/rejected) based on reduction ratio ρk |
| test/runtests.jl | Added assertions to verify step_status is :unknown at iter==0 and :accepted at iter>0 for all solver tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #297 +/- ##
===========================================
+ Coverage 61.53% 83.51% +21.98%
===========================================
Files 11 13 +2
Lines 1292 1656 +364
===========================================
+ Hits 795 1383 +588
+ Misses 497 273 -224 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MaxenceGollier
merged commit b20b029
into
JuliaSmoothOptimizers:master
16 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following JuliaSmoothOptimizers/SolverCore.jl#130,
users can now access the step status in the callback through the
stats.