Add computation function for bounds and initialize bounds#240
Merged
MaxenceGollier merged 1 commit intoOct 1, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #240 +/- ##
===========================================
+ Coverage 61.53% 84.62% +23.09%
===========================================
Files 11 13 +2
Lines 1292 1620 +328
===========================================
+ Hits 795 1371 +576
+ Misses 497 249 -248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thank you @MaxenceGollier, have you tested while incorporating the changes in this PR? |
Collaborator
Author
|
No, it works even without these changes (on the nnmf problem) |
Member
|
I still think it's important to initialize |
dpo
approved these changes
Oct 1, 2025
b868635
into
JuliaSmoothOptimizers:master
13 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on zulip.
Solves your bug @MohamedLaghdafHABIBOULLAH