Skip to content

Implement SolverCore.reset!(solver) function #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxenceGollier merged 5 commits into from
Feb 20, 2026
Merged

Implement SolverCore.reset!(solver) function #293

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ae6e2e
add _reset_power_norm function
MaxenceGollier Feb 13, 2026
c194e13
add LinearOperators.reset! to reset! quasi-Newton approximations
MaxenceGollier Feb 13, 2026
302a7b9
fix _reset_power_method to correct output
MaxenceGollier Feb 13, 2026
73836e7
implement SolverCore.reset!(solver) functions
MaxenceGollier Feb 13, 2026
3c898ec
add condition on B before resetting
MaxenceGollier Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/R2N.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ function SolverCore.solve!(
sub_kwargs::NamedTuple = NamedTuple(),
) where {T, V, G}
reset!(stats)
_reset_power_method!(solver.v0)
Comment thread
MaxenceGollier marked this conversation as resolved.
Outdated

# Retrieve workspace
selected = reg_nlp.selected
Expand Down
1 change: 1 addition & 0 deletions src/TR_alg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ function SolverCore.solve!(
compute_grad::Bool = true,
) where {T, G, V}
reset!(stats)
_reset_power_method!(solver.v0)
Comment thread
MaxenceGollier marked this conversation as resolved.
Outdated

# Retrieve workspace
selected = reg_nlp.selected
Expand Down
5 changes: 5 additions & 0 deletions src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ export RegularizedExecutionStats

import SolverCore.GenericExecutionStats

# Reset the initial vector for the power method to [-1/sqrt(n), 1/sqrt(n), -1/sqrt(n), ...].
function _reset_power_method!(v0::AbstractVector)
v0 .= (isodd.(eachindex(v0)) .* -2 .+ 1) ./ sqrt(length(v0))
Comment thread
MaxenceGollier marked this conversation as resolved.
Outdated
Comment thread
MaxenceGollier marked this conversation as resolved.
Outdated
end
Comment thread
MaxenceGollier marked this conversation as resolved.
Outdated

function power_method!(B::M, v₀::S, v₁::S, max_iter::Int = 1) where {M, S}
@assert max_iter >= 1 "max_iter must be at least 1."
mul!(v₁, B, v₀)
Expand Down
Loading