remove the demos workflow#301
Merged
MaxenceGollier merged 1 commit intoJuliaSmoothOptimizers:masterfrom Feb 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the demos.yml GitHub Actions workflow that was responsible for running example demonstrations (demo-bpdn, demo-bpdn-constr, demo-nnmf-constr) and uploading the generated PDF artifacts. According to the PR description, this workflow is being replaced with a benchmark workflow.
Changes:
- Deleted the
.github/workflows/demos.ymlworkflow file which ran example demonstrations on push to master and on pull requests
Comments suppressed due to low confidence (1)
.github/workflows/demos.yml:1
- The workflow
.github/workflows/pr-comment.ymldepends on the "demos" workflow (line 4 of pr-comment.yml) and will fail when this workflow is removed. The pr-comment.yml file referencesworkflows: ["demos"]in itsworkflow_runtrigger. If the demos workflow is being replaced with a benchmark workflow, the pr-comment.yml should be updated to reference the new workflow name instead, or should be removed if no longer needed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
===========================================
+ Coverage 61.53% 83.51% +21.98%
===========================================
Files 11 13 +2
Lines 1292 1656 +364
===========================================
+ Hits 795 1383 +588
+ Misses 497 273 -224 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MaxenceGollier
merged commit 8b7a6b7
into
JuliaSmoothOptimizers:master
17 checks passed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dpo, will replace it with a benchmark workflow.