Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a JSOBenchmarks-based benchmarking setup for this Julia package, including a dedicated benchmark environment and a GitHub Actions workflow to run benchmarks on demand (via PR labeling or workflow calls).
Changes:
- Added
benchmark/benchmarks.jldefining a BenchmarkToolsSUITEfor selected solvers/problems. - Added
benchmark/Project.tomlto define the benchmark environment dependencies. - Added
.github/workflows/jsobmarks.ymlto run benchmarks in CI, post results as a PR comment, and upload artifacts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
benchmark/benchmarks.jl |
Defines the BenchmarkTools suite entries for BPDN variants and solver(s). |
benchmark/Project.toml |
Introduces a benchmark-only Julia environment for running the suite. |
.github/workflows/jsobmarks.yml |
Adds a CI workflow to run JSOBenchmarks on labeled PRs / workflow calls and report results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
MaxenceGollier
left a comment
There was a problem hiding this comment.
Thank you @dpo.
My only comment is to make the name of the label clearer, like those from ADNLPModels.jl.
Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
MaxenceGollier
approved these changes
Mar 4, 2026
Collaborator
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.