Skip to content

JSO Benchmarks#307

Merged
dpo merged 12 commits into
masterfrom
jsobmarks
Mar 5, 2026
Merged

JSO Benchmarks#307
dpo merged 12 commits into
masterfrom
jsobmarks

Conversation

@dpo
Copy link
Copy Markdown
Member

@dpo dpo commented Mar 4, 2026

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a JSOBenchmarks-based benchmarking setup for this Julia package, including a dedicated benchmark environment and a GitHub Actions workflow to run benchmarks on demand (via PR labeling or workflow calls).

Changes:

  • Added benchmark/benchmarks.jl defining a BenchmarkTools SUITE for selected solvers/problems.
  • Added benchmark/Project.toml to define the benchmark environment dependencies.
  • Added .github/workflows/jsobmarks.yml to run benchmarks in CI, post results as a PR comment, and upload artifacts.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
benchmark/benchmarks.jl Defines the BenchmarkTools suite entries for BPDN variants and solver(s).
benchmark/Project.toml Introduces a benchmark-only Julia environment for running the suite.
.github/workflows/jsobmarks.yml Adds a CI workflow to run JSOBenchmarks on labeled PRs / workflow calls and report results.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/jsobmarks.yml
Comment thread benchmark/Project.toml
Comment thread benchmark/benchmarks.jl Outdated
Comment thread .github/workflows/jsobmarks.yml
Copy link
Copy Markdown
Collaborator

@MaxenceGollier MaxenceGollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dpo.

My only comment is to make the name of the label clearer, like those from ADNLPModels.jl.

Comment thread .github/workflows/jsobmarks.yml Outdated
dpo and others added 2 commits March 4, 2026 16:29
Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
@MaxenceGollier
Copy link
Copy Markdown
Collaborator

LGTM.
Should we squash or rebase in this type of situation where there are lot of small "debugging" commits ?

@dpo dpo merged commit 7286dc8 into master Mar 5, 2026
13 checks passed
@dpo dpo deleted the jsobmarks branch March 5, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants