Skip to content

avoid overwriting methods in CompositeOp tests#147

Merged
dpo merged 1 commit intomasterfrom
compositeop-tests-overwriting
Oct 11, 2025
Merged

avoid overwriting methods in CompositeOp tests#147
dpo merged 1 commit intomasterfrom
compositeop-tests-overwriting

Conversation

@dpo
Copy link
Copy Markdown
Member

@dpo dpo commented Oct 11, 2025

closes #146

@dpo dpo requested a review from Copilot October 11, 2025 19:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes function name conflicts in CompositeOp tests by renaming duplicate function definitions to avoid overwriting methods during test execution.

  • Renamed duplicate c! functions to c1! and c2! to prevent conflicts
  • Renamed duplicate J! functions to J1! and J2! to prevent conflicts
  • Updated corresponding function calls to use the new names

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dpo
Copy link
Copy Markdown
Member Author

dpo commented Oct 11, 2025

The remaining failures are those of #145.

@dpo dpo merged commit 2917b8b into master Oct 11, 2025
5 of 12 checks passed
@dpo dpo deleted the compositeop-tests-overwriting branch October 11, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix overwritten methods in unit tests

2 participants