Skip to content

avoid overwriting methods in CompositeOp tests #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpo merged 1 commit into from
Oct 11, 2025
Merged

avoid overwriting methods in CompositeOp tests #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ for (op, composite_op, shifted_op) ∈
ShiftedOp = eval(shifted_op)
CompositeOp = eval(composite_op)

function c!(z, x)
function c1!(z, x)
z[1] = 2*x[1] - x[4]
z[2] = x[2] + x[3]
end
function J!(z, x)
function J1!(z, x)
z.vals .= Float64[2.0, 1.0, 1.0, -1.0]
end
λ = 3.62
Expand All @@ -27,7 +27,7 @@ for (op, composite_op, shifted_op) ∈
b = zeros(Float64, 2)
A = SparseMatrixCOO(Float64[2 0 0 -1; 0 1 1 0])

ψ = CompositeOp(λ, c!, J!, A, b)
ψ = CompositeOp(λ, c1!, J1!, A, b)

# test non shifted operator
@test ψ(ones(Float64, 4)) == h([1, 2])
Expand Down Expand Up @@ -66,17 +66,17 @@ for (op, composite_op, shifted_op) ∈

# test different types
h = Op(Float32(λ))
function c!(z, x)
function c2!(z, x)
z[1] = 2*x[1] - x[4]
z[2] = x[2] + x[3]
end
function J!(z, x)
function J2!(z, x)
z.vals .= Float32[2.0, 1.0, 1.0, -1.0]
end
b = zeros(Float32, 2)
A = SparseMatrixCOO(Float32[2 0 0 -1; 0 1 1 0])

ψ = CompositeOp(Float32(λ), c!, J!, A, b)
ψ = CompositeOp(Float32(λ), c2!, J2!, A, b)

@test typeof(ψ(zeros(Float32, 4))) == Float32

Expand Down
Loading