Fix allocations test errors#151
Conversation
…ations errors on julia lts
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 73.71% 77.32% +3.60%
==========================================
Files 22 24 +2
Lines 898 966 +68
==========================================
+ Hits 662 747 +85
+ Misses 236 219 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
💪 QRMumps.jl#136 should fix for Julia 1 now. Just need to solve on nightly. |
|
@MaxenceGollier I suggest to use |
…l the function twice
|
For your info @amontoison, I was able to solve the issue on Julia I only have the QRMumps.jl related failures now. |
| argnames = [gensym() for a in expr.args] | ||
| quote | ||
| function g($(argnames...)) | ||
| $(Expr(expr.head, argnames...)) |
There was a problem hiding this comment.
Oh, do you do the warm-start this way?
It is neat!
Fixes the memory issue in ShiftedComposite
b3035c4
into
JuliaSmoothOptimizers:master
closes #145
See #145 (comment).
I guess that test will fail on lts with this but we should try to make 0 allocations on lts and not the other way around.