Skip to content

Commit 0c2b44c

Browse files
jishnubaraujoms
andauthored
Move nonzeroinds to LinearAlgebra (#678)
This builds on JuliaLang/LinearAlgebra.jl#1534. One issue with this would be that direct uses of `SparseArrays.nonzeroinds` would lead to warnings: ```julia julia> s = sparsevec([2, 6], [2,3]) 6-element SparseVector{Int64, Int64} with 2 stored entries: [2] = 2 [6] = 3 julia> SparseArrays.nonzeroinds(s) [ Warning: nonzeroinds is defined in LinearAlgebra and is not public in SparseArrays 2-element Vector{Int64}: 2 6 ``` This may be remedied by making the function public, but then this had not been declared as `public` anyway. The other alternative might be to retain the function in `SparseArrays` and just add a method to the one from `LinearAlgebra`, as in the PR linked above. Co-authored-by: Mateus Araújo <maltusan@gmail.com>
1 parent 40d5de2 commit 0c2b44c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/SparseArrays.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import Base: Matrix, Vector
1919
import LinearAlgebra: mul!, ldiv!, rdiv!, cholesky, adjoint!, diag, eigen, dot,
2020
issymmetric, istril, istriu, lu, tr, transpose!, tril!, triu!, isbanded, isdiag,
2121
cond, diagm, factorize, ishermitian, norm, opnorm, lmul!, rmul!, tril, triu,
22-
matprod_dest, generic_matvecmul!, generic_matmatmul!, generic_matmatmul_wrapper!, copytrito!
22+
matprod_dest, generic_matvecmul!, generic_matmatmul!, generic_matmatmul_wrapper!, copytrito!, nonzeroinds
2323

2424
import Base: adjoint, argmin, argmax, Array, broadcast, circshift!, complex, Complex,
2525
conj, conj!, convert, copy, copy!, copyto!, count, diff, findall, findmax, findmin,

0 commit comments

Comments
 (0)