Skip to content

Commit ef56ea2

Browse files
authored
Remove some unnecessary methods that cause invalidations (#694)
1 parent 6a610ef commit ef56ea2

2 files changed

Lines changed: 0 additions & 4 deletions

File tree

src/solvers/cholmod.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1287,11 +1287,9 @@ function size(F::Factor, i::Integer)
12871287
return 1
12881288
end
12891289
size(F::Factor) = (size(F, 1), size(F, 2))
1290-
axes(A::Union{Dense,Sparse,Factor}) = map(Base.OneTo, size(A))
12911290

12921291
IndexStyle(::Type{<:Dense}) = IndexLinear()
12931292

1294-
size(FC::FactorComponent, i::Integer) = size(FC.F, i)
12951293
size(FC::FactorComponent) = size(FC.F)
12961294

12971295
adjoint(FC::FactorComponent{Tv,:L}) where {Tv} = FactorComponent{Tv,:U}(FC.F)

src/solvers/spqr.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ struct QRSparseQ{Tv,Ti<:Integer} <: AbstractQ{Tv}
115115
end
116116

117117
Base.size(Q::QRSparseQ) = (size(Q.factors, 1), size(Q.factors, 1))
118-
Base.axes(Q::QRSparseQ) = map(Base.OneTo, size(Q))
119118

120119
Matrix{T}(Q::QRSparseQ) where {T} = lmul!(Q, Matrix{T}(I, size(Q, 1), min(size(Q, 1), Q.n)))
121120

@@ -154,7 +153,6 @@ function Base.size(F::QRSparse, i::Integer)
154153
throw(ArgumentError("second argument must be positive"))
155154
end
156155
end
157-
Base.axes(F::QRSparse) = map(Base.OneTo, size(F))
158156

159157
# From SPQR manual p. 6
160158
_default_tol(A::AbstractSparseMatrixCSC) =

0 commit comments

Comments
 (0)