Fix and test reuse_symbolic=false for UMFPACK lu!()#712
Merged
araujoms merged 2 commits intoMay 7, 2026
Conversation
johnomotani
force-pushed
the
fix-umfpack-reuse_symbolic-is-false
branch
from
ca58792 to
126e589
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
==========================================
- Coverage 84.42% 84.40% -0.03%
==========================================
Files 13 13
Lines 9400 9400
==========================================
- Hits 7936 7934 -2
- Misses 1464 1466 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Instead of copy-pasting the entire test you could add another loop |
Contributor
Author
@araujoms - done. |
araujoms
approved these changes
May 7, 2026
Contributor
araujoms
left a comment
araujoms
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
ViralBShah
pushed a commit
that referenced
this pull request
May 25, 2026
The `reuse_symbolic=false` option for UMFPACK's `lu!()` is broken, due to undefined `Tv` and `Ti`. This PR fixes that bug, and adds a test that uses `reuse_symbolic=false`. (cherry picked from commit 40d5de2)
dkarrasch
added a commit
that referenced
this pull request
May 26, 2026
…723) Backports seven PRs to `release-1.13` via `git cherry-pick -x`: - #709 — fix cholesky linear solve with sparse rhs (commit 754280c) - #710 — make `zero` preserve indextype (commit 405a8d5) - #712 — Fix and test `reuse_symbolic=false` for UMFPACK `lu!()` (commit 40d5de2) - #716 — test: avoid method-overwrite warnings in forbidproperties.jl (commit f7b1e19) - #720 — Add trailing whitespace check (commit 5926672) - #721 — sparsematrix: fix `swaprows!` storage moves (commit 85f7b74) - #722 — fix `findmin`/`findmax` with `NaN` (commit 3f9b6fb) All cherry-picked cleanly with no conflicts. Each commit retains its `(cherry picked from commit …)` trailer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
reuse_symbolic=falseoption for UMFPACK'slu!()is broken, due to undefinedTvandTi. This PR fixes that bug, and adds a test that usesreuse_symbolic=false.