Skip to content

test: avoid method-overwrite warnings in forbidproperties.jl #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PatrickHaecker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: avoid method-overwrite warnings in forbidproperties.jl #716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions test/forbidproperties.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# This file is a part of Julia. License is MIT: https://julialang.org/license

using SparseArrays
Base.getproperty(::SparseMatrixCSC, ::Symbol) = error("use accessor function")
Base.getproperty(::SparseVector, ::Symbol) = error("use accessor function")
# Only define each `getproperty` override if it isn't already defined. This
# file is `include`d from multiple sibling test modules, and without this
# guard each subsequent include would re-set the same `Base` methods,
# producing spurious method-overwrite warnings (depending on `--warn-overwrite`).
# `hasmethod` is not sufficient here because the generic `Base.getproperty`
# fallback for `Any` always exists; we instead check whether `which` returns
# that fallback method.
let fallback = which(Base.getproperty, Tuple{Any, Symbol})
if which(Base.getproperty, Tuple{SparseMatrixCSC, Symbol}) === fallback
Base.getproperty(::SparseMatrixCSC, ::Symbol) = error("use accessor function")
end
if which(Base.getproperty, Tuple{SparseVector, Symbol}) === fallback
Base.getproperty(::SparseVector, ::Symbol) = error("use accessor function")
end
end
Loading