Add trailing whitespace check#720
Merged
Merged
Conversation
Adds .ci/check-whitespace.jl (adapted from JuliaLang/julia's contrib/check-whitespace.jl) and a GitHub Actions workflow that runs it on push/PR. Also fixes pre-existing whitespace violations across the source and test trees. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
- Coverage 84.36% 84.35% -0.02%
==========================================
Files 13 13
Lines 9376 9376
==========================================
- Hits 7910 7909 -1
- Misses 1466 1467 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ViralBShah
added a commit
that referenced
this pull request
May 25, 2026
## Summary - Adds `.ci/check-whitespace.jl`, adapted from [JuliaLang/julia's `contrib/check-whitespace.jl`](https://github.com/JuliaLang/julia/blob/master/contrib/check-whitespace.jl), with patterns trimmed to files relevant to this repo (`*.jl`, `*.md`, `*.yml`, `*Makefile`). - Adds `.github/workflows/Whitespace.yml` to run the check on push to `main` and on pull requests. - Fixes pre-existing whitespace violations (trailing whitespace, trailing blank lines, a non-breaking space) so the new check passes. Companion to JuliaLang/LinearAlgebra.jl#1633. ## Test plan - [x] `julia .ci/check-whitespace.jl` reports no issues locally - [x] Whitespace workflow passes in CI 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> (cherry picked from commit 5926672)
dkarrasch
added a commit
that referenced
this pull request
May 26, 2026
…723) Backports seven PRs to `release-1.13` via `git cherry-pick -x`: - #709 — fix cholesky linear solve with sparse rhs (commit 754280c) - #710 — make `zero` preserve indextype (commit 405a8d5) - #712 — Fix and test `reuse_symbolic=false` for UMFPACK `lu!()` (commit 40d5de2) - #716 — test: avoid method-overwrite warnings in forbidproperties.jl (commit f7b1e19) - #720 — Add trailing whitespace check (commit 5926672) - #721 — sparsematrix: fix `swaprows!` storage moves (commit 85f7b74) - #722 — fix `findmin`/`findmax` with `NaN` (commit 3f9b6fb) All cherry-picked cleanly with no conflicts. Each commit retains its `(cherry picked from commit …)` trailer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ci/check-whitespace.jl, adapted from JuliaLang/julia'scontrib/check-whitespace.jl, with patterns trimmed to files relevant to this repo (*.jl,*.md,*.yml,*Makefile)..github/workflows/Whitespace.ymlto run the check on push tomainand on pull requests.Companion to JuliaLang/LinearAlgebra.jl#1633.
Test plan
julia .ci/check-whitespace.jlreports no issues locally🤖 Generated with Claude Code