Backports to release-1.13: #709, #710, #712, #716, #720, #721, #722 by ViralBShah · Pull Request #723 · JuliaSparse/SparseArrays.jl

ViralBShah · 2026-05-25T16:18:06Z

Backports seven PRs to release-1.13 via git cherry-pick -x:

fix cholesky linear solve with sparse rhs #709 — fix cholesky linear solve with sparse rhs (commit 754280c)
make zero preserve indextype #710 — make zero preserve indextype (commit 405a8d5)
Fix and test reuse_symbolic=false for UMFPACK lu!() #712 — Fix and test reuse_symbolic=false for UMFPACK lu!() (commit 40d5de2)
test: avoid method-overwrite warnings in forbidproperties.jl #716 — test: avoid method-overwrite warnings in forbidproperties.jl (commit f7b1e19)
Add trailing whitespace check #720 — Add trailing whitespace check (commit 5926672)
sparsematrix: fix swaprows! storage moves #721 — sparsematrix: fix swaprows! storage moves (commit 85f7b74)
fix findmin/findmax with nan #722 — fix findmin/findmax with NaN (commit 3f9b6fb)

All cherry-picked cleanly with no conflicts. Each commit retains its (cherry picked from commit …) trailer.

reported on discourse, mostly oneshot by codex 5.5 ---------------------------------------------------------------------------------------------------------------- Fix SparseMatrixCSC row swaps when exactly one swapped row is stored in a column. The j search range used a local i index as an absolute storage index, and the single-row move rotations were reversed. On master: ```julia julia> A = sparse([1.0 2.0 3.0; 0.0 0.0 0.0; 4.0 5.0 6.0]); Base.swaprows!(A, 1, 2); A 3×3 SparseMatrixCSC{Float64, Int64} with 6 stored entries: ⋅ 1.0 ⋅ 2.0 ⋅ 3.0 4.0 5.0 6.0 julia> B = sparse(reshape([1.0, 2.0, 3.0, 4.0, 0.0, 0.0], 6, 1)); Base.swaprows!(B, 2, 6); rowvals(B) 4-element Vector{Int64}: 1 4 6 3 ``` --------- Co-authored-by: OpenAI Codex <codex@openai.com> (cherry picked from commit 85f7b74)

Closes #714 (cherry picked from commit 3f9b6fb)

The `reuse_symbolic=false` option for UMFPACK's `lu!()` is broken, due to undefined `Tv` and `Ti`. This PR fixes that bug, and adds a test that uses `reuse_symbolic=false`. (cherry picked from commit 40d5de2)

Closes #574 The appropriate function to extract the index type is `indtype`, not `keytype`. Since it already works correctly the only thing to do is fix the `zero` method. (cherry picked from commit 405a8d5)

Closes #630 (cherry picked from commit 754280c)

Co-authored-by: Patrick Häcker <patrick.haecker@bosch.com> Co-authored-by: Copilot <copilot@github.com> (cherry picked from commit f7b1e19)

## Summary - Adds `.ci/check-whitespace.jl`, adapted from [JuliaLang/julia's `contrib/check-whitespace.jl`](https://github.com/JuliaLang/julia/blob/master/contrib/check-whitespace.jl), with patterns trimmed to files relevant to this repo (`*.jl`, `*.md`, `*.yml`, `*Makefile`). - Adds `.github/workflows/Whitespace.yml` to run the check on push to `main` and on pull requests. - Fixes pre-existing whitespace violations (trailing whitespace, trailing blank lines, a non-breaking space) so the new check passes. Companion to JuliaLang/LinearAlgebra.jl#1633. ## Test plan - [x] `julia .ci/check-whitespace.jl` reports no issues locally - [x] Whitespace workflow passes in CI 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> (cherry picked from commit 5926672)

codecov · 2026-05-25T16:48:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.41%. Comparing base (0ecfa6f) to head (32f78fc).

Additional details and impacted files

@@              Coverage Diff              @@
##           release-1.13     #723   +/-   ##
=============================================
  Coverage         84.40%   84.41%           
=============================================
  Files                13       13           
  Lines              9392     9391    -1     
=============================================
  Hits               7927     7927           
+ Misses             1465     1464    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ViralBShah · 2026-05-25T17:22:09Z

@dkarrasch Wanted to get your eyes on these backports.

adienes and others added 3 commits May 25, 2026 12:17

fix findmin/findmax with nan (#722)

7eb244f

Closes #714 (cherry picked from commit 3f9b6fb)

Fix and test reuse_symbolic=false for UMFPACK lu!() (#712)

5fc293c

The `reuse_symbolic=false` option for UMFPACK's `lu!()` is broken, due to undefined `Tv` and `Ti`. This PR fixes that bug, and adds a test that uses `reuse_symbolic=false`. (cherry picked from commit 40d5de2)

ViralBShah changed the title ~~Backports to release-1.13: #721, #722~~ Backports to release-1.13: #712, #721, #722 May 25, 2026

make zero preserve indextype (#710)

853e709

Closes #574 The appropriate function to extract the index type is `indtype`, not `keytype`. Since it already works correctly the only thing to do is fix the `zero` method. (cherry picked from commit 405a8d5)

ViralBShah changed the title ~~Backports to release-1.13: #712, #721, #722~~ Backports to release-1.13: #710, #712, #721, #722 May 25, 2026

fix cholesky linear solve with sparse rhs (#709)

019a782

Closes #630 (cherry picked from commit 754280c)

ViralBShah changed the title ~~Backports to release-1.13: #710, #712, #721, #722~~ Backports to release-1.13: #709, #710, #712, #721, #722 May 25, 2026

test: avoid method-overwrite warnings in forbidproperties.jl (#716)

f647b92

Co-authored-by: Patrick Häcker <patrick.haecker@bosch.com> Co-authored-by: Copilot <copilot@github.com> (cherry picked from commit f7b1e19)

ViralBShah changed the title ~~Backports to release-1.13: #709, #710, #712, #721, #722~~ Backports to release-1.13: #709, #710, #712, #716, #721, #722 May 25, 2026

ViralBShah changed the title ~~Backports to release-1.13: #709, #710, #712, #716, #721, #722~~ Backports to release-1.13: #709, #710, #712, #716, #720, #721, #722 May 25, 2026

dkarrasch approved these changes May 26, 2026

View reviewed changes

dkarrasch merged commit 5e8f00c into release-1.13 May 26, 2026
13 checks passed

dkarrasch deleted the backport-721-722-to-release-1.13 branch May 26, 2026 11:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backports to release-1.13: #709, #710, #712, #716, #720, #721, #722#723

Backports to release-1.13: #709, #710, #712, #716, #720, #721, #722#723
dkarrasch merged 7 commits into
release-1.13from
backport-721-722-to-release-1.13

ViralBShah commented May 25, 2026 •

edited

Loading

Uh oh!

codecov Bot commented May 25, 2026 •

edited

Loading

Uh oh!

ViralBShah commented May 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ViralBShah commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ViralBShah commented May 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ViralBShah commented May 25, 2026 •

edited

Loading

codecov Bot commented May 25, 2026 •

edited

Loading