expand ignore functionality to consistently allow ignoring submodules#165
Merged
ericphanson merged 7 commits intomainfrom Jan 14, 2026
Merged
expand ignore functionality to consistently allow ignoring submodules#165ericphanson merged 7 commits intomainfrom
ignore functionality to consistently allow ignoring submodules#165ericphanson merged 7 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the ignore functionality to consistently allow ignoring submodules across all check functions. Previously, the ignore parameter primarily supported ignoring specific symbols; now it consistently supports ignoring entire submodule trees as well.
Changes:
- Added helper functions (
is_ignored_submodule,validate_ignore_submodules) to handle submodule-based ignoring - Updated all check functions to validate and apply submodule ignoring
- Added
merge_ignorefunction intest_explicit_importsto merge top-level and per-check ignore lists - Comprehensive test coverage for the new functionality
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/checks.jl | Added helper functions for submodule ignoring and integrated them into all check functions; updated documentation |
| src/test_explicit_imports.jl | Added merge_ignore function and integrated ignore parameter into test_explicit_imports |
| test/ignore_modules.jl | New test module definitions covering all check function scenarios |
| test/ignore_modules_test.jl | Comprehensive tests for submodule ignoring functionality |
| test/runtests.jl | Integrated new test files and added merge behavior tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #164