Skip to content

Add --test flag for app#166

Merged
ericphanson merged 2 commits intomainfrom
eph/app-test
Jan 14, 2026
Merged

Add --test flag for app#166
ericphanson merged 2 commits intomainfrom
eph/app-test

Conversation

@ericphanson
Copy link
Copy Markdown
Member

to use new test functionality with #143

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a --test flag to the ExplicitImports command-line application, enabling users to run Test.jl-style checks instead of printing results. This complements the existing --check and --print functionality.

Changes:

  • Added --test flag to run Test.jl-style checks via test_explicit_imports()
  • Implemented mutual exclusivity between --test and --check/--checklist flags
  • Updated help text and README documentation to describe the new flag

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/main.jl Added --test flag parsing, mutual exclusivity check, and execution logic for running test-style checks
test/main.jl Added comprehensive tests for the new --test flag, including tests for standalone usage and mutual exclusivity with other flags
README.md Updated documentation to include the new --test option in the OPTIONS section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main.jl
Comment on lines +253 to +254
printstyled(stderr, "ERROR: "; bold=true, color=:red)
Base.showerror(stderr, e)
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a newline after the error output for better formatting. This would ensure the error message is properly terminated regardless of whether the exception's error formatting includes a trailing newline. This same pattern exists in other error handling blocks in this file (lines 108-109, 244-245), so for consistency, all instances should be updated together if this change is made.

Copilot uses AI. Check for mistakes.
@ericphanson ericphanson merged commit b601cfd into main Jan 14, 2026
14 checks passed
@ericphanson ericphanson deleted the eph/app-test branch January 14, 2026 10:00
ericphanson referenced this pull request Jan 14, 2026
…es (#165)

* expand `ignore` functionality to consistently allow ignoring submodules of the package

* validate ignores & tweak wording

* add tests for validation

* tweak wording

* add top-level ignore to `test_` fn

* rm unnecessary fn

* rm another unused fn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants